Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bicycle rental capacity quest #4008

Merged
merged 12 commits into from
May 15, 2022
Merged

Add bicycle rental capacity quest #4008

merged 12 commits into from
May 15, 2022

Conversation

FloEdelmann
Copy link
Member

Fixes #2129.

Test/screenshot location: https://www.openstreetmap.org/node/9135891817

Copy link
Collaborator

@peternewman peternewman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Improve the quest order.

Co-authored-by: Peter Newman <peternewman@users.noreply.github.com>
Copy link
Member

@westnordost westnordost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

I wonder if releasing this quest should be delayed until a bicycle rental type quest has been created, so surveyors don't need to visit a place twice for solving the related quest types.

@HolgerJeromin
Copy link
Contributor

I wonder if releasing this quest should be delayed until a bicycle rental type quest has been created, so surveyors don't need to visit a place twice for solving the related quest types.

We could disable the quest till the other quest is ready.

to be consistent with wording of other quests
@westnordost westnordost merged commit 5e90700 into streetcomplete:master May 15, 2022
@FloEdelmann FloEdelmann deleted the bicycle-rental-capacity branch May 16, 2022 05:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bicycle Rental (docking station) capacity
6 participants