-
-
Notifications
You must be signed in to change notification settings - Fork 352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add bicycle rental capacity quest #4008
Add bicycle rental capacity quest #4008
Conversation
...main/java/de/westnordost/streetcomplete/quests/bike_rental_capacity/AddBikeRentalCapacity.kt
Outdated
Show resolved
Hide resolved
...main/java/de/westnordost/streetcomplete/quests/bike_rental_capacity/AddBikeRentalCapacity.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Improve the quest order.
app/src/main/java/de/westnordost/streetcomplete/quests/QuestsModule.kt
Outdated
Show resolved
Hide resolved
Co-authored-by: Peter Newman <peternewman@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
I wonder if releasing this quest should be delayed until a bicycle rental type quest has been created, so surveyors don't need to visit a place twice for solving the related quest types.
...main/java/de/westnordost/streetcomplete/quests/bike_rental_capacity/AddBikeRentalCapacity.kt
Outdated
Show resolved
Hide resolved
...main/java/de/westnordost/streetcomplete/quests/bike_rental_capacity/AddBikeRentalCapacity.kt
Outdated
Show resolved
Hide resolved
We could disable the quest till the other quest is ready. |
...ava/de/westnordost/streetcomplete/quests/bike_parking_capacity/AddBikeParkingCapacityForm.kt
Show resolved
Hide resolved
to be consistent with wording of other quests
Fixes #2129.
Test/screenshot location: https://www.openstreetmap.org/node/9135891817