Bbq fuel quest (Issue #4832) #5211
Conversation
app/src/main/java/de/westnordost/streetcomplete/quests/bbq_fuel/AddBBQFuel.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/de/westnordost/streetcomplete/quests/bbq_fuel/AddBBQFuel.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/de/westnordost/streetcomplete/quests/bbq_fuel/AddBBQFuel.kt
Outdated
Show resolved
Hide resolved
…l/AddBBQFuel.kt Co-authored-by: Flo Edelmann <git@flo-edelmann.de>
Co-authored-by: Flo Edelmann <git@flo-edelmann.de>
…l/AddBBQFuel.kt Co-authored-by: Flo Edelmann <git@flo-edelmann.de>
There was a problem hiding this comment.
Code looks flawless and you thought of every little thing (even attribution etc).
The monochrome icon is pretty boring though, if not ugly. It will be some time till this is merged anyway so I'd take care of this then.
One thing I noticed, generally, while looking at the PR, is that it is kind of really involved to create a new quest as one needs to touch so many files.
Looking at what could be changed, I wonder if the whole PinIcons stuff should be dropped and instead always the icons of the fitting iD presets should be used instead.
Also, I wonder if it was more neatly arranged if the model (in this case, BbqFuel) went into the same file as the quest, as it is somewhat related. I mean, generally, in the future, not for this PR.
What do you think?
|
(needs icon) |
My first attempt of implementing this quest from Issue #4832