Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New quests: BBQ #4832

Closed
5 tasks done
michalgwo opened this issue Feb 20, 2023 · 15 comments
Closed
5 tasks done

New quests: BBQ #4832

michalgwo opened this issue Feb 20, 2023 · 15 comments
Labels
new quest accepted new quest proposal (if marked as blocked, it may require upstream work first)

Comments

@michalgwo
Copy link
Contributor

michalgwo commented Feb 20, 2023

General

We can add 3 quests for amenity=bbq

  1. covered
  • Question asked: Is this place protected from rain?
  • Answers: yes/no
  1. fuel
  • Question asked: What is this grill powered by?
  • Answers: wood/electric/charcoal
  1. wood_provided (in case of fuel=wood)
  • Question asked: Is wood provided by the operator of this bbq?
  • Answers: yes/no

Checklist

Checklist for quest suggestions (see guidelines):

  • 🚧 To be added tag is established and has a useful purpose
  • 🤔 Any answer the user can give must have an equivalent tagging (Quest should not reappear to other users when solved by one)
  • 🐿️ Easily answerable by any pedestrian from the outside but a survey is necessary
  • 💤 Not an overwhelming percentage of quests have the same answer (No spam)
  • 🕓 Applies to a reasonable number of map data (Worth the effort)
@FloEdelmann FloEdelmann mentioned this issue Feb 20, 2023
5 tasks
@mnalis
Copy link
Member

mnalis commented Feb 20, 2023

And they could have Other answers - It is not a bbq, but a firepit, replacing amenity=bbq with leisure=firepit .

@letypequividelespoubelles

And you could add a fourth (yes/no) question : Is there a grate ?

@arrival-spring
Copy link
Contributor

The BBQ page says that fuel may typically not be provided, but the fuel page doesn't say what to tag if no fuel is provided.

The value no has been used, but only 92 times so is hardly established.

@matkoniecz
Copy link
Member

matkoniecz commented Feb 22, 2023

How many public BBQ are covered? 1% of all? less? more? (note that it is distinct from "how many bbg with covered have yes value" as covered ones are more likely to be tagged with covered key)

@michalgwo
Copy link
Contributor Author

The BBQ page says that fuel may typically not be provided, but the fuel page doesn't say what to tag if no fuel is provided.

The value no has been used, but only 92 times so is hardly established.

From my understanding, fuel here means how the bbq is powered, not what is provided.

How many public BBQ are covered? 1% of all? less? more? (note that it is distinct from "how many bbg with covered have yes value" as covered ones are more likely to be tagged with covered key)

I don't know the statistics, but I don't think its uncommon, I've seen it a couple of times. Photo from my town below.

2022-05-28

@andrewharvey
Copy link
Contributor

Could also ask for capacity=*, ie. How many cooking surfaces are available at this BBQ? I commonly encounter 1, 2 sometimes more.

@westnordost westnordost added the new quest accepted new quest proposal (if marked as blocked, it may require upstream work first) label Mar 10, 2023
@westnordost
Copy link
Member

1 and 2 seem useful.

@matkoniecz
Copy link
Member

barbecue cover quest part is covered by #4905

@roptat and others: is anyone interested in implementing

Question asked: What is this grill powered by?
Answers: wood/electric/charcoal

It seems to be friendly one for starting with StreetComplete coding ( https://github.com/streetcomplete/StreetComplete/blob/master/CONTRIBUTING_A_NEW_QUEST.md may help )

@qugebert
Copy link
Contributor

barbecue cover quest part is covered by #4905

@roptat and others: is anyone interested in implementing

Question asked: What is this grill powered by?
Answers: wood/electric/charcoal

It seems to be friendly one for starting with StreetComplete coding ( https://github.com/streetcomplete/StreetComplete/blob/master/CONTRIBUTING_A_NEW_QUEST.md may help )

Here's my attempt of implementing this quest: #5211
Please tell me, if i made any mistakes, but it worked fine when i tested it.

@derfasthirnlosenick
Copy link

I'd also put a "do you have to pay for this BBQ?" At least for certain countries.

At least in Australia, coin operated BBQs used to be a thing.

@andrewharvey
Copy link
Contributor

I'd also put a "do you have to pay for this BBQ?" At least for certain countries.

At least in Australia, coin operated BBQs used to be a thing.

I'm all for asking the question as more complete data is better, but I've never encountered one that's paid before.

Asking, "Is this BBQ still in working order?" would be a good idea given many break down and are left unpaired.

@derfasthirnlosenick
Copy link

derfasthirnlosenick commented Sep 4, 2023

I'm all for asking the question as more complete data is better, but I've never encountered one that's paid before.

I'd country-restrict the quest anyway - never seen one outside Australia (where they are everywhere), though. Google says they might exist in New Zealand and potentially also USA and Canada.

westnordost added a commit that referenced this issue Oct 13, 2023
* BBQ_Fuel-Quest

* Update QuestsModule.kt

* add Element highlighting to AddBBQFuel

* Update app/src/main/java/de/westnordost/streetcomplete/quests/bbq_fuel/AddBBQFuel.kt

Co-authored-by: Flo Edelmann <git@flo-edelmann.de>

* Update app/src/main/res/values/strings.xml

Co-authored-by: Flo Edelmann <git@flo-edelmann.de>

* Update app/src/main/java/de/westnordost/streetcomplete/quests/bbq_fuel/AddBBQFuel.kt

Co-authored-by: Flo Edelmann <git@flo-edelmann.de>

* Rename AddBbqFuel-Quest (camel-case)

* use different quest icon

---------

Co-authored-by: Flo Edelmann <git@flo-edelmann.de>
Co-authored-by: Tobias Zwick <newton@westnordost.de>
@qugebert
Copy link
Contributor

qugebert commented Oct 14, 2023

Ok, i see this is still open. so to summarize:
We had various quests requested here, two of them are already implemented

@westnordost Is this issue finished now or should i implement any of these remaining requests? I'm not really sure, if any of them would make so much sense.

@mnalis
Copy link
Member

mnalis commented Nov 17, 2023

This one has been covered by other answer here: PR #5371

Dunno, haven't really seen those in Croatia nor neighboring countries. If it is common is some countries (it would need research in which ones first), it should be restricted to such countries, and made dependent on fuel=wood answer on existing quest.

I don't see much use of that (also, is 1 big surface worse than 2 small ones? Would we tag width/length? It's not worth it, IMHO).

I agree. Perhaps if some county has them commonly, it might be limited to such countries, but unless someone comes up with such research, I wouldn't bother.

In short, I would think this can be closed as completed unless someone steps forward with research for those unimplemented quests.

@matkoniecz
Copy link
Member

closing, but feel free to file new issues (using new quest issue template) if any of remaining quests is viable

(one quest per issue is best)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new quest accepted new quest proposal (if marked as blocked, it may require upstream work first)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants