Skip to content
This repository has been archived by the owner on Aug 14, 2024. It is now read-only.

Fix flickering labels and disappearing quest pins #142

Merged
merged 1 commit into from
Dec 6, 2022

Conversation

Helium314
Copy link
Contributor

This is the PR for #136.
I honestly have no clue why it helps, especially because setting priority without toString works as expected in place-labels

@westnordost
Copy link
Member

Shouldn't the same fix be made for every other place where a javascript function returns the priority?

@Helium314
Copy link
Contributor Author

I tested for place-labels, and there priority works with and without toString, and I haven't seen any disappearing quest pin or flickering label in the tests I did with the current PR state.

So I would say it's not necessary to apply the fix in other places, as there is nothing else to fix... which is why I mentioned above that I have no clue why the change actually helps.
I think it shouldn't help, but it for some reason it does. I can only encourange you to go to the house in streetcomplete/StreetComplete#4522 (comment) and try for yourself...

@westnordost
Copy link
Member

I can only encourange you to go to the house in streetcomplete/StreetComplete#4522 (comment) and try for yourself...

Actually, I can't reproduce the issue at that house already now. Do you know another location where the current issue is reliably reproducible?

@Helium314
Copy link
Contributor Author

Still works for me: go to max. zoom, zoom out two steps (or one and rotate) and the pin is gone.

@westnordost
Copy link
Member

Which pin for example?

@Helium314
Copy link
Contributor Author

The pin for the building type quest. Looks like this (49.2 from F-Droid):
building

@westnordost
Copy link
Member

Right. I can reproduce it there. And I fiddled around some more, adding semicolons, wrapping the other functions in toString etc. and it looks like this is the only and the minimal fix to workaround this odd bug in tangram. Thank you!

@westnordost westnordost merged commit 6e96d41 into streetcomplete:jawg Dec 6, 2022
@Helium314 Helium314 deleted the patch-1 branch December 6, 2022 19:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants