Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Ignore IDREF values for HTML #252

Merged
merged 1 commit into from
Oct 30, 2020
Merged

feat: Ignore IDREF values for HTML #252

merged 1 commit into from
Oct 30, 2020

Conversation

nschonni
Copy link
Collaborator

No description provided.

@nschonni nschonni mentioned this pull request Oct 27, 2020
Closed
@Jason3S
Copy link
Collaborator

Jason3S commented Oct 29, 2020 •
edited

It is possible to check out the results with cspell:
cspell check -c cspell-ext.json sample.html

Looks like the data definition is too agressive:
image

@nschonni
Copy link
Collaborator Author

Thanks! I wonder if that's the data rule that's being to greedy

@Jason3S
Copy link
Collaborator

Jason3S commented Oct 29, 2020

Thanks! I wonder if that's the data rule that's being to greedy

Looks like it: https://regex101.com/r/mJt0tR/1

@Jason3S
Copy link
Collaborator

Jason3S commented Oct 29, 2020

Maybe something like this:
https://regex101.com/r/mJt0tR/2

@nschonni
Copy link
Collaborator Author

I think the data one should probably be dropped since it's not actually a IDREF field

@Jason3S Jason3S merged commit 5c1014f into streetsidesoftware:master Oct 30, 2020
@nschonni nschonni deleted the html-idref-ignore-regexp branch October 30, 2020 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jason3S Jason3S Jason3S left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nschonni @Jason3S