-
-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Additional ignores for HTML IDREF properties #437
Conversation
Codecov Report
@@ Coverage Diff @@
## master #437 +/- ##
=======================================
Coverage 98.42% 98.42%
=======================================
Files 85 85
Lines 3609 3609
Branches 604 604
=======================================
Hits 3552 3552
Misses 54 54
Partials 3 3 Continue to review full report at Codecov.
|
"languageId": "html", | ||
"ignoreRegExpList": [ | ||
"href", | ||
"id=\"(?:[^\\\"]+|\\.)*\"", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would you define these as patterns in html/cspell-ext.json like found in python/cspell-ext.json?
Then then can be turned on/off and even overridden in case they do not perform so well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, I also wasn't sure if these should be a named regex like "href"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using named patterns has some advantages.
- It becomes easier to know what it should do (assuming it is a good name).
- It can be overridden easily with an improved pattern.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, I can see it being a combine regex, maybe called "IDRef" or something similar, as that's what these represent. Do you have a preference to doing that here and using the named regex in this place, or just shifting it to cspell-dicts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would rather have them defined in cspell-dict/packages/html/cspell-ext.json. That way they can be changed independently from the tool.
Closing in favour of streetsidesoftware/cspell-dicts#252 |
No description provided.