Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Additional ignores for HTML IDREF properties #437

Closed
wants to merge 2 commits into from

Conversation

nschonni
Copy link
Collaborator

No description provided.

@coveralls
Copy link

coveralls commented Oct 25, 2020

Coverage Status

Coverage increased (+2.2%) to 100.0% when pulling 3f9b2c6 on nschonni:ignore-idrefs into 7df2080 on streetsidesoftware:master.

@codecov
Copy link

codecov bot commented Oct 25, 2020

Codecov Report

Merging #437 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #437   +/-   ##
=======================================
  Coverage   98.42%   98.42%           
=======================================
  Files          85       85           
  Lines        3609     3609           
  Branches      604      604           
=======================================
  Hits         3552     3552           
  Misses         54       54           
  Partials        3        3           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7df2080...3f9b2c6. Read the comment docs.

"languageId": "html",
"ignoreRegExpList": [
"href",
"id=\"(?:[^\\\"]+|\\.)*\"",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would you define these as patterns in html/cspell-ext.json like found in python/cspell-ext.json?

Then then can be turned on/off and even overridden in case they do not perform so well.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I also wasn't sure if these should be a named regex like "href"

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using named patterns has some advantages.

  1. It becomes easier to know what it should do (assuming it is a good name).
  2. It can be overridden easily with an improved pattern.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I can see it being a combine regex, maybe called "IDRef" or something similar, as that's what these represent. Do you have a preference to doing that here and using the named regex in this place, or just shifting it to cspell-dicts?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would rather have them defined in cspell-dict/packages/html/cspell-ext.json. That way they can be changed independently from the tool.

@nschonni
Copy link
Collaborator Author

Closing in favour of streetsidesoftware/cspell-dicts#252

@nschonni nschonni closed this Oct 27, 2020
@nschonni nschonni deleted the ignore-idrefs branch October 27, 2020 02:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants