feat: Add a dictionary for Docker keywords #1117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobysmith568
force-pushed
the
ts/docker-dict
branch
from
cfb9f2c
to
79c69b1
Compare
tobysmith568
force-pushed
the
ts/docker-dict
branch
from
79c69b1
to
46de8cf
Compare
|
Thank you. Too bad the yarn command didn't work for you. I fixed a few things to get it working. |
|
Hey @Jason3S , thanks for patching up this PR and then merging 🚀 |
No problem. I think it is a worthy dictionary. Is yarn installed on your machines? |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @Jason3S - would you accept a docker dictionary?
The following dockerfile instructions aren't currently present in any of the dictionaries that ship with the
cspellnpm package:Though I added the rest of the dockerfile keywords for consistency.
I could be wrong but I don't think there are any keywords used in docker compose files that aren't in the en_us dictionary?
I wasn't able to run the yarn commands in this repo as I'm on Windows. Even in WSL Ubuntu I couldn't quite get them working. So if you're happy with this dictionary being added then let me know if there's anything I've overlooked or need to generate? I had to manually edit the
All Dictionariestable in the readme, for example.