Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Start populating people-names dict #3290

Merged
merged 1 commit into from
Jun 14, 2024

Conversation

arkid15r
Copy link
Sponsor Collaborator

Fix Dictionary

Dictionary: people-names

Description

Add a couple hundred of names to people-names dict

References

The contents is mostly based on a Python Holidays authors file (it's a one of open-source projects I've been taking care of).

@Jason3S a quick question if I may. So I started following the best practice by adding the new items at the end of the files. What would be the best way to make sure I'm don't add existing (within the same dictionary) terms. Is there a CI/CD control step that makes terms unique? Or maybe it's the contributors/reviewers responsibility?

Thank you!

Checklist

  • By submitting this pull-request, you agree to follow our Code of Conduct
  • Verify that the title starts with the correct prefix:
    • fix: - for minor changes like adding words or fixing spelling issues.
    • feat: - for a significant change like adding a whole new set of words to a dictionary.
    • feat!: - for breaking changes, like file format or licensing changes.
    • chore: - for changes that do not impact the content of dictionaries.

@Jason3S
Copy link
Collaborator

Jason3S commented Jun 14, 2024

@arkid15r,

Thank you. Duplicate values get removed during the CI/CD sort process. If the same word exists in multiple source files, the duplicates are removed during the dictionary build step so only a single entry exists in the resulting dictionary.

@Jason3S Jason3S merged commit 30f6f2c into streetsidesoftware:main Jun 14, 2024
8 checks passed
@github-actions github-actions bot mentioned this pull request Jun 14, 2024
@arkid15r arkid15r deleted the update-people-names-dict branch June 14, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants