fix: #2077

streetsidesoftware · Dec 18, 2021 · 93ba917 · 93ba917
1 parent 5885501
commit 93ba917
Show file tree

Hide file tree

Showing 4 changed files with 23 additions and 6 deletions.
diff --git a/.eslintrc.js b/.eslintrc.js
@@ -11,7 +11,7 @@ const config = {
         'plugin:node/recommended',
         'plugin:import/errors',
         'plugin:import/warnings',
-        // 'plugin:promise/recommended',
+        'plugin:promise/recommended',
         'plugin:prettier/recommended',
     ],
     ignorePatterns: [

diff --git a/integration-tests/src/check.ts b/integration-tests/src/check.ts
@@ -237,11 +237,7 @@ function asPendingPromise<T>(promise: Promise<T>): PendingPromise<T> {
         state: 'pending',
     };
 
-    // x-eslint-disable-next-line promise/catch-or-return
-    promise.then(
-        (v) => ((pp.state = 'resolved'), v),
-        (r) => ((pp.state = 'rejected'), r)
-    );
+    promise.then((v) => ((pp.state = 'resolved'), v)).catch((r) => ((pp.state = 'rejected'), r));
 
     return pp;
 }

diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -75,6 +75,7 @@
     "eslint-plugin-jest": "^25.3.0",
     "eslint-plugin-node": "^11.1.0",
     "eslint-plugin-prettier": "^4.0.0",
+    "eslint-plugin-promise": "^6.0.0",
     "globcat": "^2.0.0",
     "jest": "^27.4.5",
     "lerna": "^4.0.0",