Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OpenWeatherMap API 2.5 deprecation #442

Open
Ryuno-Ki opened this issue Apr 24, 2024 · 4 comments
Open

OpenWeatherMap API 2.5 deprecation #442

Ryuno-Ki opened this issue Apr 24, 2024 · 4 comments

Comments

@Ryuno-Ki
Copy link
Contributor

Hey there 馃憢

I recently received an e-mail by OpenWeatherMap that they are going to sundown API 2.5 in June this year.

They were so kind to link to https://openweathermap.org/one-call-transfer for an upgrade path.

Since I'm using OpenWeatherMap myself I was wondering whether you would be open to a PR upgrading to the new API?
How can we communicate that a new API token will be required? I couldn't come up with a good way for this myself.
Ryuno-Ki added a commit to Ryuno-Ki/awesome-wm-widgets that referenced this issue Jun 17, 2024
@Ryuno-Ki
refactor: rewrite weather.lua to use WeatherAPI
39d72e4 
When I looked into OpenWeatherMap 3.0 API they demanded credit card
information even for their free tier. Therefore I decided to move to
another provider with a generous tier.

In a first step I rewrote the current weather report (i.e. no forecast)
to use it.

I haven't received any commentary on streetturtle#442 so I don't know where your
mind was going. If OpenWeatherMap phases out its 2.5 API and nobody else
intends to use their 3.0 one, I offer to take this implementation
instead.

Signed-off-by: Andr茅 Jaenisch <andre.jaenisch@posteo.de>
@Ryuno-Ki Ryuno-Ki mentioned this issue Jun 17, 2024
Open
@Ryuno-Ki
Copy link
Contributor Author

I've opened #448 in case someone else is relying on Weather reporting as well. No forecast yet (as I wrapped my head around how to get the current weather rendered in Lua).

@Ryuno-Ki
Copy link
Contributor Author

FWIW I just spotted #394 which uses another service.
I could imagine allowing the awesome people to choose which service they want to use as WeatherAPI is also requiring an API key (but does not need a change in its API in rc.lua).

Opinions?

@streetturtle
Copy link
Owner

The widget in #394 is visually different from this one, I'll ask the maintainer if they would be ok to move it in this repo. I think it would be too much work to make theese widgets look the same, as the data those two APIs (OWM and wttr) return could be different.

@streetturtle
Copy link
Owner

Hey @Ryuno-Ki, thank you for starting this migration!
I think the best way to proceed with migration to the weatherapi.com would be to create a new widget (we can call it weather-api-widget for example) and add a deprecation notice to this one's readme. New users will definitely check the readme, and hopefully existing will check it, when the OWM API stops working.
What do you think?
If you ok with it, please add a new widget, and I'll take care of the deprecation notice in the readme.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Ryuno-Ki @streetturtle