Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Space left on the top of editor after deleting first list item #132

Closed
abhishekarora12 opened this issue Dec 2, 2021 · 7 comments
Closed
Labels
Status: Waiting for Release The fix is done but is waiting for release. Type: Bug Something isn't working
Milestone

Comments

@abhishekarora12
Copy link

If a list is at the top of note, after deleting the first item, the space left before the list can't be removed by delete button in mac

@ammarahm-ed ammarahm-ed added the Type: Bug Something isn't working label Dec 2, 2021
@thecodrr thecodrr modified the milestones: 1.6.9, 1.6.10 Dec 2, 2021
@thecodrr thecodrr modified the milestones: 1.6.10, 1.6.11, 1.6.12 Dec 10, 2021
@thecodrr thecodrr added the Status: Can't reproduce Can't reproduce this issue on any device or platform. label Dec 11, 2021
@thecodrr
Copy link
Contributor

I couldn't reproduce this on v1.6.11, can you test again?

@abhishekarora12
Copy link
Author

Describe the bug
I'll rephrase - Pressing delete button on mac when the caret is at the top of the page even when there is content on the page, doesn't do anything

Ideal Behavior
The delete button should delete the top empty line and move to the title, so the list also comes to the top

Screenshare
https://user-images.githubusercontent.com/12087783/146254918-a861442b-b4ce-44bc-a155-01f4c611d703.mov

Device

  • OS: OS X 10.15.7
  • Browser Electron 15.0.0
  • App version: 1.6.11-f72f04a-desktop
  • Pro: true

@thecodrr
Copy link
Contributor

The delete button should delete the top empty line and move to the title, so the list also comes to the top

Delete button or backspace? Delete button is working as it should (i.e. deleting the empty line and moving the list back). The backspace doesn't work because there is literally nothing behind the caret. Title is not part of the editor space so you can't just jump to it.

@abhishekarora12
Copy link
Author

There is only a delete button on mac

@abhishekarora12
Copy link
Author

Have this same issue in android as well. Can't take the list to the top if you backspace the first element in the list.
@thecodrr Please open this issue again.

@thecodrr thecodrr reopened this Dec 22, 2021
@Tamnac
Copy link

Tamnac commented Dec 27, 2021

@thecodrr I think the issue is there is no way to delete an empty first line except by backspacing from previous line. To see how this is a problem, try this:

  1. Make a new note
  2. Write some text in first line
  3. make a table on the second line
  4. delete text in the first line

You now have a blank first line with no way to remove it, or move the table to the top.

@thecodrr
Copy link
Contributor

Perhaps what we can do is to also allow backspacing the first empty line if it exists.

@thecodrr thecodrr added Status: Confirmed Bug is confirmed but work on a fix hasn't yet started. and removed Status: Can't reproduce Can't reproduce this issue on any device or platform. labels Dec 30, 2021
@thecodrr thecodrr removed this from the 1.6.12 milestone Dec 30, 2021
@thecodrr thecodrr added this to the 1.7.4 milestone Jan 4, 2022
@thecodrr thecodrr added Status: Waiting for Release The fix is done but is waiting for release. and removed Status: Confirmed Bug is confirmed but work on a fix hasn't yet started. labels Jan 4, 2022
@thecodrr thecodrr closed this as completed Jan 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Waiting for Release The fix is done but is waiting for release. Type: Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants