Fix issue where a single item could have duplicate shortcuts #1177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this was not exactly a bug but it can cause a lot of unintended behaviour. Previously, you'd have to manually specify which version the item migration should jump to. This was buggy and poorly designed. This change makes the item iterate over all the db migrations one by one automatically. For example: An item at version 5.2 will go through: - 5.3 - 5.4 - and so on
This should not affect the items or their server representation. This change is necessary to allow multiple items with same id that live in different collections. For example, shortcuts have the same id as the inner reference they point to. This was not possible before and would cause an overwrite of the original value.
this changes the shortcut ids & deduplicates the old ones so that there is always only 1 shortcut of a given item (notebook, topic or tag).
This was
linked to
issues
Oct 12, 2022
Closed
This was
linked to
issues
Oct 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This needs to be quite heavily tested especially the syncing. We also might have to move the database version ahead to stop potential issues on older versions.