Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option to change default font size & font family in editor #1721

Merged
merged 10 commits into from Apr 17, 2023
Merged

Add option to change default font size & font family in editor #1721

merged 10 commits into from Apr 17, 2023

Conversation

alihamuh
Copy link
Collaborator

No description provided.

@alihamuh alihamuh linked an issue Jan 18, 2023 that may be closed by this pull request
Allow changing default font size & font family #1500
Closed
@thecodrr thecodrr linked an issue Jan 18, 2023 that may be closed by this pull request
More fonts and default font/font size #1719
Open
@thecodrr thecodrr changed the title web: added change default fontstyle feature in the settings Add option to change default font size & font family in editor Jan 19, 2023
thecodrr
thecodrr requested changes Jan 19, 2023
View reviewed changes
Copy link
Contributor

@thecodrr thecodrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both the settings are not stateful i.e. changing their values will require restarting the app.

@alihamuh alihamuh linked an issue Jan 27, 2023 that may be closed by this pull request
Default font size? #75
Closed
@alihamuh
Copy link
Collaborator Author

okay

@ammarahm-ed ammarahm-ed self-assigned this Apr 7, 2023
@ammarahm-ed ammarahm-ed mentioned this pull request Apr 7, 2023
Closed
@ammarahm-ed ammarahm-ed merged commit 3bf6b52 into master Apr 17, 2023
7 checks passed
@ammarahm-ed ammarahm-ed deleted the change-default-font branch April 17, 2023 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thecodrr thecodrr thecodrr requested changes

Assignees

@ammarahm-ed ammarahm-ed

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

More fonts and default font/font size Allow changing default font size & font family Default font size?
3 participants
@alihamuh @thecodrr @ammarahm-ed