Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core: disable color-name-sanitization #2274

Merged
merged 3 commits into from
Apr 15, 2023
Merged

core: disable color-name-sanitization #2274

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b28f530
core: disable-colorname-sanitization
Apr 5, 2023
00575cb
core: disabled the sanitization for the colors tag
Apr 6, 2023
4afe76a
core: disabled sanitization on renaming in all cases
Apr 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 2 additions & 3 deletions apps/web/src/common/dialog-controller.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,9 +209,8 @@ export function showError(title: string, message: string) {
export function showMultiDeleteConfirmation(length: number) {
return confirm({
title: `Delete ${length} items?`,
message: `These items will be **kept in your Trash for ${
db.settings?.getTrashCleanupInterval() || 7
} days** after which they will be permanently deleted.`,
message: `These items will be **kept in your Trash for ${db.settings?.getTrashCleanupInterval() || 7
} days** after which they will be permanently deleted.`,
Abdulrehman-Jafer marked this conversation as resolved.
Show resolved Hide resolved
positiveButtonText: "Yes",
negativeButtonText: "No"
});
Expand Down
3 changes: 0 additions & 3 deletions packages/core/collections/tags.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,9 +79,6 @@ export default class Tags extends Collection {
return;
}

newName = this.sanitize(newName);
if (!newName) throw new Error("Tag title cannot be empty.");

await this._db.settings.setAlias(tagId, newName);
await this._collection.addItem({ ...tag, alias: newName });
}
Expand Down