Update CONTRIBUTING.md #2384
Merged
Update CONTRIBUTING.md #2384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Elmin Didic <35606145+ElminD@users.noreply.github.com>
thecodrr
requested changes
Apr 19, 2023
CONTRIBUTING.md
Outdated
| @@ -81,15 +81,15 @@ The DCO is a declaration attached to every contribution made by every developer | |||
|
|
|||
| **Each commit must include a DCO which looks like this:** | |||
|
|
|||
| ```txt | |||
| "`txt | |||
There was a problem hiding this comment.
We are creating a codeblock here. The requested change here is incorrect.
CONTRIBUTING.md
Outdated
| Signed-off-by: Jane Smith <jane.smith@email.com> | ||
| ``` | ||
|
|
||
| On VSCode, it looks like this: | ||
|
|
||
|  | ||
|
|
||
| You may type this line on your own when writing your commit messages. However, if your [user.name](http://user.name) and [user.email](http://user.email) are set in your git configs, you can use `-s` or `--signoff` to add the `Signed-off-by` line to the end of the commit message automatically. | ||
| You may type this line on your own when writing your commit messages. However, if your [user.name](http://user.name) and [user.email](http://user.email) are set in your git configs, you can use `-s' or `--signoff` to add the `Signed-off-by` line to the end of the commit message automatically. |
There was a problem hiding this comment.
The requested change here is incorrect.
CONTRIBUTING.md
Outdated
| @@ -119,7 +119,7 @@ All commits must include valid scopes in the commit message. **Valid commit scop | |||
|
|
|||
| **Some example commits would look like this:** | |||
|
|
|||
| ```txt | |||
| "`txt | |||
There was a problem hiding this comment.
The requested change here is incorrect.
Signed-off-by: Elmin Didic <35606145+ElminD@users.noreply.github.com>
|
Should be all fixed |
thecodrr
reviewed
Apr 25, 2023
Signed-off-by: Abdullah Atta <thecodrr@protonmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I used Grammarly and other tools to update the file
docs: Updated grammar Contributing
Signed-off-by: Elmin Didic [edidic@iastate.edu]