Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add clipboard button to the Codeblock #2710

Merged
merged 11 commits into from Jul 5, 2023
Merged

Add clipboard button to the Codeblock #2710

merged 11 commits into from Jul 5, 2023

Conversation

FMMazur
Copy link
Contributor

@FMMazur FMMazur commented Jun 10, 2023

Solve: #2657

@FMMazur
editor: add clipboard button and handler
6bf4058 
Signed-off-by: Felipe Muñoz Mazur <felipe.munoz.mazur@protonmail.com>
@FMMazur
mobile: add handler on copy event
e1054a9 
Signed-off-by: Felipe Muñoz Mazur <felipe.munoz.mazur@protonmail.com>
@FMMazur
web: add copy handler to options
a492b34 
Signed-off-by: Felipe Muñoz Mazur <felipe.munoz.mazur@protonmail.com>
@FMMazur
editor: fix selection condition
080e2af 
Signed-off-by: Felipe Muñoz Mazur <felipe.munoz.mazur@protonmail.com>
thecodrr
thecodrr requested changes Jun 12, 2023
View reviewed changes
Copy link
Contributor

@thecodrr thecodrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! Thanks for this. However, there are a few changes necessary.

packages/editor/src/extensions/code-block/component.tsx Outdated Show resolved Hide resolved
packages/editor/src/extensions/code-block/code-block.ts Outdated Show resolved Hide resolved
packages/editor/src/extensions/code-block/component.tsx Outdated Show resolved Hide resolved
packages/editor/src/extensions/code-block/component.tsx Outdated Show resolved Hide resolved
packages/editor/src/extensions/code-block/highlighter.ts Outdated Show resolved Hide resolved
@thecodrr
Copy link
Contributor

@FMMazur what's the status on this?

FMMazur and others added 4 commits June 17, 2023 06:06
@FMMazur
editor: handle copy with writeText.
7b28517 
Signed-off-by: Felipe Muñoz Mazur <felipe.munoz.mazur@protonmail.com>
@FMMazur
mobile: remove copy event
d797d76 
Signed-off-by: Felipe Muñoz Mazur <felipe.munoz.mazur@protonmail.com>
@FMMazur
web: remove copy command
bae21b8 
Signed-off-by: Felipe Muñoz Mazur <felipe.munoz.mazur@protonmail.com>
@FMMazur
Merge branch 'master' into feature/codeblock-copy-button
36970e6 
Signed-off-by: Felipe Muñoz Mazur <36215582+FMMazur@users.noreply.github.com>
@FMMazur
Copy link
Contributor Author

FMMazur commented Jun 17, 2023

@FMMazur what's the status on this?

I didn't have time to touch it during the week, as it was just removing stuff I did and tested today, at least the web and desktop version, I couldn't test on mobile.

thecodrr
thecodrr requested changes Jun 19, 2023
View reviewed changes
Copy link
Contributor

@thecodrr thecodrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also run npm run bootstrap so the package-lock.json file gets updated.

packages/editor/src/extensions/code-block/component.tsx Outdated Show resolved Hide resolved
packages/editor/src/extensions/image/image.ts Outdated Show resolved Hide resolved
packages/editor/src/index.ts Outdated Show resolved Hide resolved
packages/editor/src/index.ts Outdated Show resolved Hide resolved
packages/editor/src/types.ts Outdated Show resolved Hide resolved
packages/editor/src/extensions/code-block/code-block.ts Outdated Show resolved Hide resolved
thecodrr and others added 2 commits June 19, 2023 12:06
@thecodrr
editor: undo unnecessary changes
3effaea 
Signed-off-by: Abdullah Atta <thecodrr@protonmail.com>
@FMMazur
common: update package-lock.json
1d305ba 
Signed-off-by: Felipe Muñoz Mazur <felipe.munoz.mazur@protonmail.com>
@thecodrr
Copy link
Contributor

CI is still complaining about Missing: clipboard-polyfill@4.0.0 from lock file.

@thecodrr
Copy link
Contributor

thecodrr commented Jul 5, 2023

@FMMazur ping

@thecodrr thecodrr merged commit 5c9f7a8 into streetwriters:master Jul 5, 2023
1 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thecodrr thecodrr thecodrr requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@FMMazur @thecodrr