-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Colorize "expected" and "actual" #946
Comments
It's an interesting idea. I'm slightly leaning towards keeping testify as simple as possible but ultimately we do it for the community. If there is strong support for this, I'd be happy to look into it :) |
I like this idea. Perhaps the default should be set to the current behaviour and starting 2.0 we could enable it by default? @boyan-soubachov I'd say let's do this assuming we can keep it a lightweight and KISSy solution. Anyone any concrete ideas for a PR? |
Agreed with @arsham. I think it makes a lot more sense to provide the interface which users can customize. Not all users can see specific colours the same or well, not all colours have the same meanings to all people, etc. |
So, since we're agreed that this is a nice idea... Here's an initial spec sheet for this new feature:
For now I don't think it should be more than this. |
This will detect when running in interactive vs non-iterative mode (i.e. I don't want to see control characters in logged output). |
Are there plans to merge #1232? |
Just here to say that I would also love a little bit of colour! It makes it a little bit easier for people's eyes to parse the information dump that they see on the screen. Seems like a good addition to the suite 👍 |
Can we have an option to colorize "expected" and "actual" in test output? Like this:
![Screenshot from 2020-05-13 18-27-59](https://user-images.githubusercontent.com/16285118/81802475-ba0fc100-9548-11ea-8d31-5a335b23981b.png)
For me the colors helps because it allows me to locate the diff faster. This kind of coloring is very common in Node.js test frameworks.
The text was updated successfully, but these errors were encountered: