Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misplaced "expected" and "actual" Arguments Inside InEpsilonSlice #1231

Closed
vaguecoder opened this issue Jul 17, 2022 · 2 comments · Fixed by #1483 · May be fixed by #1232
Closed

Misplaced "expected" and "actual" Arguments Inside InEpsilonSlice #1231

vaguecoder opened this issue Jul 17, 2022 · 2 comments · Fixed by #1483 · May be fixed by #1232
Labels
bug good first issue help wanted pkg-assert Change related to package testify/assert

Comments

@vaguecoder
Copy link

Both InEpsilon and InEpsilonSlice has parameter expected before actual

func InEpsilon(t TestingT, expected, actual interface{}, epsilon float64, msgAndArgs ...interface{}) bool
func InEpsilonSlice(t TestingT, expected, actual interface{}, epsilon float64, msgAndArgs ...interface{}) bool

However, InEpsilon's call inside InEpsilonSlice has the arguments misplaced:

result := InEpsilon(t, actualSlice.Index(i).Interface(), expectedSlice.Index(i).Interface(), epsilon)
@premkirank
Copy link

@vaguecoder can you assign this to me? I would like to work on this if this is still open.

@dolmen
Copy link
Collaborator

dolmen commented Oct 10, 2023

@vaguecoder @premkirank Please review #1483.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug good first issue help wanted pkg-assert Change related to package testify/assert
Projects
None yet
3 participants