Skip to content
This repository has been archived by the owner on Apr 24, 2019. It is now read-only.

Commit

Permalink
Clean up and rename initial test
Browse files Browse the repository at this point in the history
  • Loading branch information
edgenard committed May 13, 2018
1 parent aecb9ac commit 72de92f
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions refactoring_external_service/youtube_video_list_spec.rb
Original file line number Original file line Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ def video_stats(ids=:NotGivenToStub)
end end
end end


def test_video_list_returns_video_list def test_when_views_unchanged_for_one_month

This comment has been minimized.

Copy link
@medwards1771

medwards1771 May 15, 2018

Contributor

Wait a second, what does view count have to do with anything?

video_repo_response = [{'youtubeID' => 'blahblahblah', 'views' => 3, 'monthlyViews' => 3}] video_repo_response = [{'youtubeID' => 'blahblahblah', 'views' => 3, 'monthlyViews' => 3}]
youtube_client_response = {'items' => youtube_client_response = {'items' =>
[ [
Expand All @@ -41,7 +41,6 @@ def test_video_list_returns_video_list
video_repo: VideoRepoStub.new(video_repo_response), video_repo: VideoRepoStub.new(video_repo_response),
video_client: YoutubeVideoClientStub.new(youtube_client_response) video_client: YoutubeVideoClientStub.new(youtube_client_response)
) )
video_json = JSON.generate(video_repo_response)


actual = JSON.parse(video_service.video_list) actual = JSON.parse(video_service.video_list)
expected = video_repo_response expected = video_repo_response
Expand Down

0 comments on commit 72de92f

Please sign in to comment.