fix: strdiag001 on file scoped classes (#2309)

Co-authored-by: IXLLEGACYIXL <ixllegacy123@outlook.com>
stride3d · Jun 7, 2024 · 8b07e0b · 8b07e0b
1 parent c1b36e1
commit 8b07e0b
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/sources/core/Stride.Core.CompilerServices.Tests/AnalyzerTests/STRDIAG001_Test.cs b/sources/core/Stride.Core.CompilerServices.Tests/AnalyzerTests/STRDIAG001_Test.cs
@@ -21,8 +21,7 @@ public void No_Error_On_Private_Inner_Class_without_DataContract()
         string sourceCode = string.Format(ClassTemplates.BasicClassTemplate, "private class InnerClass { }");
         TestHelper.ExpectNoDiagnosticsErrors(sourceCode);
     }
-    // TODO: Enable with .NET8 merge as we need a higher C# version
-    [Fact(Skip = "file scoped classes won't compile")]
+    [Fact]
     public void Error_On_file_scope_Class_with_DataContract()
     {
         string sourceCode = "using Stride.Core; [DataContract] file class FileScopeClass { }";

diff --git a/sources/core/Stride.Core.CompilerServices/Analyzers/STRDIAG001InvalidDataContract.cs b/sources/core/Stride.Core.CompilerServices/Analyzers/STRDIAG001InvalidDataContract.cs
@@ -49,7 +49,10 @@ private static void AnalyzeSymbol(SymbolAnalysisContext context, INamedTypeSymbo
         if (!symbol.HasAttribute(dataContractAttribute))
             return;
 
-        if(!symbol.IsVisibleToSerializer(hasDataMemberAttribute: true))
+        if (symbol.IsFileLocal)
+            Rule.ReportDiagnostics(context, symbol);
+
+        if (!symbol.IsVisibleToSerializer(hasDataMemberAttribute: true))
             Rule.ReportDiagnostics(context, symbol);
     }
 }