Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: strdiag001 on file scoped classes #2309

Merged
merged 1 commit into from
Jun 7, 2024

Conversation

IXLLEGACYIXL
Copy link
Collaborator

@IXLLEGACYIXL IXLLEGACYIXL commented Jun 5, 2024

PR Details

file scope didnt work as its not an accessor like public internal, this is now fixed

Related Issue

fix #2263

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My change requires a change to the documentation.
  • I have added tests to cover my changes. ( was just disabled )
  • All new and existing tests passed.
  • I have built and run the editor to try this change out. ( doesnt affect editor at all )

@IXLLEGACYIXL
Copy link
Collaborator Author

thats it, there is nothing more to add to fix it

@Eideren Eideren merged commit 8b07e0b into stride3d:master Jun 7, 2024
13 of 14 checks passed
@Eideren
Copy link
Collaborator

Eideren commented Jun 7, 2024

Thanks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compilerservices File Scoped doesnt work
3 participants