[Upgrader] Skip specific package prefixed with Stride from auto-upgra…

…de (#2093)
stride3d · Jan 21, 2024 · b3f6b96 · b3f6b96
1 parent 6e8e532
commit b3f6b96
Show file tree

Hide file tree

Showing 2 changed files with 39 additions and 1 deletion.
diff --git a/sources/assets/Stride.Core.Assets/StridePackagesToSkipUpgrade.cs b/sources/assets/Stride.Core.Assets/StridePackagesToSkipUpgrade.cs
@@ -0,0 +1,21 @@
+// Copyright (c) .NET Foundation and Contributors (https://dotnetfoundation.org/ & https://stride3d.net)
+// Distributed under the MIT license. See the LICENSE.md file in the project root for more information.
+using System.Collections.Generic;
+
+namespace Stride.Core.Assets;
+
+public static class StridePackagesToSkipUpgrade
+{
+    public static string[] PackageNames =
+    [
+        "Stride.Awesome.Shaders",
+        // In case other packages are added with the community namespace,
+        "Stride.Community.",
+        "Stride.CommunityToolkit",
+        "Stride.GraphX.WPF.Controls",
+        "Stride.GNU.Gettext",
+        "Stride.OpenTK",
+        "Stride.Metrics",
+        "Stride.BepuPhysics",
+    ];
+}
diff --git a/sources/engine/Stride.Assets/StridePackageUpgrader.cs b/sources/engine/Stride.Assets/StridePackageUpgrader.cs
@@ -145,8 +145,25 @@ public override bool UpgradeBeforeAssembliesLoaded(PackageLoadParameters loadPar
                 {
                     var project = VSProjectHelper.LoadProject(projectFullPath.ToWindowsPath());
                     var isProjectDirty = false;
+
+                    List<Microsoft.Build.Evaluation.ProjectItem> packageReferences = new();
+                    foreach(var package in project.GetItems("PackageReference"))
+                    {
+                        bool addPackage = true;
+                        for (int i = 0; i < StridePackagesToSkipUpgrade.PackageNames.Length; i++)
+                        {
+                            if (package.EvaluatedInclude.StartsWith(StridePackagesToSkipUpgrade.PackageNames[i])
+                                || StridePackagesToSkipUpgrade.PackageNames[i].Equals(package.EvaluatedInclude))
+                            {
+                                addPackage = false;
+                            }
+                        }
 
-                    var packageReferences = project.GetItems("PackageReference").ToList();
+                        if(addPackage)
+                        {
+                            packageReferences.Add(package);
+                        }
+                    }
 
                     // Remove Stride reference for older executable projects (it was necessary in the past due to runtime.json)
                     if (dependency.Version.MinVersion < new PackageVersion("4.1.0.0")