Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate Shader Key Files #32

Open
tebjan opened this issue Aug 4, 2018 · 3 comments
Open

Duplicate Shader Key Files #32

tebjan opened this issue Aug 4, 2018 · 3 comments
Labels
area-Shaders bug Something isn't working

Comments

@tebjan
Copy link
Member

tebjan commented Aug 4, 2018

after upgrading from xenko 2.1 all custom shaders in visual studio 2017 have duplicate key files. at least game studio thinks so, although they are not actually present on disk. is there any order of things i can do to fix that? or how would i upgrade my project that this doesn't happen? i could reset the git repo and start the upgrade process again, but in which order should i open/upgrade/save the project files in game studio and visual studio?

EDIT: i have to add, the project was a VS 2015 solution. the errors occurred with 2017. currently trying to get the 2.1 version of the project running with VS 2017 and then i'll try another upgrade.

these are the errors:
unbenannt

then on build:
unbenannt2

@tebjan
Copy link
Member Author

tebjan commented Aug 4, 2018

might be related to this issue on the old repo: SiliconStudio/xenko#672

@tebjan
Copy link
Member Author

tebjan commented Aug 4, 2018

might this be a problem of the project upgrader as described here #33 ?
how should i re-include the shader files in order to get them properly handled by VS and GS?

@xen2
Copy link
Member

xen2 commented Aug 4, 2018

Yes it is related to #33 (comment)
Sorry about that, it's a one time thing related to new csproj system, that shouldn't happen during future upgrades.
Please open your project in Visual Studio, include the .xksl file as part of your project. Provided you installed the Xenko VS Plugin, it should automatically mark those files with the Custom Tool XenkoShaderKeyGenerator and the .cs embedded as a generated item.

image

If you have any trouble with Visual Studio, the .csproj looks like this:

  <ItemGroup>
    <Compile Update="Test.cs">
      <DesignTime>True</DesignTime>
      <AutoGen>True</AutoGen>
      <DependentUpon>Test.xksl</DependentUpon>
    </Compile>
    <None Update="Test.xksl">
      <Generator>XenkoShaderKeyGenerator</Generator>
      <LastGenOutput>Test.cs</LastGenOutput>
    </None>
  </ItemGroup>

@Eideren Eideren added bug Something isn't working area-Shaders labels Apr 28, 2020
Doprez pushed a commit to Doprez/stride that referenced this issue Apr 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-Shaders bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants