Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project updater removes assemblies and usages to namespaces other than xenko #33

Closed
tebjan opened this issue Aug 4, 2018 · 4 comments
Closed

Comments

@tebjan
Copy link
Member

tebjan commented Aug 4, 2018

In a game project from xenko 2.1 i was referencing some other assemblies and used their namespaces in some files. after the upgrade the project did not have the references to the assemblies anymore and the usage section of the c# files was cleared from the other namespaces. in this case it was SharpDX assemblies.

it was easy to fix by hand, so not that high priority. but annoying anyway.

@dfkeenan
Copy link
Contributor

dfkeenan commented Aug 4, 2018

Could it be that SharpDX is a special case because Xenko already has a dependency on it? Did you have similar problems for other references/using statements?

@tebjan
Copy link
Member Author

tebjan commented Aug 4, 2018

good point, since the updater removes all individual assemblies and replaces them with the single xenko package reference it seems natural that it removes the sharpdx ones. however, i just saw that there were other third party assemblies that have been removed too.

@xen2
Copy link
Member

xen2 commented Aug 4, 2018

The upgrader recreate projects using new templates, and for simplicity it doesn't handle advanced cases.
So a few things are lost:

  • Extra references
  • New glob pattern includes everything, so most files should be reincluded, but you have to be careful because it might include some extra files or miss some that were outside the main folder
  • AssemblyInfo is deleted (new project system should fill them)
  • Special files with generators such as .xksl and Contents will be missing
  • Any other csproj customization is lost.

However, since it is a one-time upgrade from 2.x to 3.x (from 3.x this shouldn't happen anymore), also it works fine for the standard cases and many people already did it anyway, I figured it was better to not spend too much time on that and focus on other things.

Sorry for the inconvenience.
Let me know if you really think it's something that should be solved, but given there were not that many 2.x users and most seem proficient enough to redo the changes they did on the csproj, I think we should be fine.

@tebjan
Copy link
Member Author

tebjan commented Aug 4, 2018

no problem, fixing the references and namespaces was easy. wouldn't wast time on a fix for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants