[Build] Native libraries get copied to runtimes/RID/native folder #1428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- In user project nuget will take care of copying required native libs to final output folder depending on used RuntimeIdentifier - Native libraries can be registered as dependencies for a later lookup (used by Stride.NuGetLoader to register native dependencies from global nuget package cache) - Fixes library not found exceptions on platforms other than windows
Source builds fine, but when testing with Android Simulator I'm getting an early crash inside of SDL/Silk. Getting same crach when running the Silk example itself. So probably unrelated.
- Tested by creating game for Android through game studio. Debug build started up (after a very long shader compile time) and I saw the Sphere getting rendered. - A release build doesn't work though. First of all the the asset compiler gets invoked four times (for each android CPU) and crashes because of files being used by other process exceptions. Why does that not happen in the debug build? Setting the RID in the project to android-arm64 fixes the asset compiler crash (because it's only invoked once now), I saw the Stide Game Engine logo but after a short black screen the app stops running. - The Android Simulator doesn't work at all. We get an early crash in Silk.NET by the used mono runtime (https://github.com/mono/mono/blob/main/mono/mini/mini-amd64.c#L765) - Had to update Silk.NET (dotnet/Silk.NET#686)
manio143
reviewed
May 16, 2022
|
A very appreciated change! |
|
Some stuff will need to stay because there's no system yet which deals with native dependency consumption in project to project references. There are a couple of issues on dotnet regarding this, for example dotnet/sdk#10575 |
|
Now that 4.1 is released, and to my understanding the build agent has been updated - can we give this one another spin? |
|
I think I was happy with those changes. @xen2 is it fine to try and merge it? |
This was referenced Mar 14, 2023
Closed
joreg
pushed a commit
to vvvv/stride
that referenced
this pull request
May 10, 2023
…eality package as well as used Silk version This broke with the merge of PR stride3d#1428 because these lines of code where added after stride3d#1428 was created.
7 tasks
This was referenced Oct 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It seems to work fine for Windows and Linux. Android worked so far that I was able to build and run in debug on a Fairphone 3. However it didn't feel stable - for example on the second attempt it started up in the wrong resolution (was only rendering on half of the screen) and after a hide/show it crashed with depth buffer having different size than render target. In release build I had to set the RID to android-arm64 or otherwise the asset compiler would get invoked multiple times tripping over itself with file in use exceptions. But these crashes seem unrelated to the changes I'm proposing here.
MacOS and iOS I couldn't test yet because of lack of Apple hardware.
Related Issue
#1061 (I tested with Linux and not OSX)
Types of changes
Checklist