Fix android template issues #1456

ykafia · 2022-07-17T08:39:21Z

PR Details

Noticed 3 issues in the android template :

possible "app_text"/"app_name" confusion
The project name is not picked up in the layout
The resources.designer.cs contains const int and are tried to be set, possible resource file issue

Types of changes

Bug fix (non-breaking change which fixes an issue)

Checklist

Update template app_text to app_name.
Find issue with the resources.designer.cs generation.
Find issue with the project name replacement

xen2 · 2022-07-17T13:46:27Z

It seems the PR doesn't contain all those 3 changes, only 1 of them (and one unrelated gitignore change)?

ykafia · 2022-07-17T13:47:42Z

Yes! i'm still investigating it, i should mark it as a draft so far

ykafia · 2022-07-17T14:38:41Z

I've solved two out of three issues but i have one last related to the resource.designer.cs file generated by xamarin.

It creates const fields and sets them in a static function which breaks everything, so i assume there might be a xamarin dependency version issue somewhere, but i can't find anything to help me with that.

If any one has a better guess i'd love to hear it

…nto fix-android-resx

Feralnex · 2022-11-18T19:19:37Z

...de.Assets.Presentation/Templates/Core/ProjectExecutable.Android/Resources/values/strings.xml

@@ -1,3 +1,2 @@
 <resources>
-    <string name="app_name"><#= Properties.PackageGameDisplayName #></string>


<Properties.PackageGameDisplayName/> works too, doesn't need to be deleted

If it was only for TextView which You deleted then ignore comment.

Thanks for the hint, do you have experience with .NET6 and android? would be nice to get this PR moving forward a bit...

I want to migrate my Android project from Unity so I've already started looking for the source of the problem with Resources.Designer.cs, but it's harder than i thought. I'll focus on it tomorrow.

Feralnex · 2022-11-23T19:08:10Z

@ykafia any ideas how to build nuget packages (....nuget\packages folders) also for net6.0-android when building Stride solution? It builds only for net6.0 and I can't reference some of the stride nuget packages inside Android project. Working on current master branch to resolve the issue with resources and this problem got in my way...

ykafia · 2022-11-23T20:37:47Z

@Feralnex so I'm not a msbuild expert but I build both Stride.sln and Stride.Android.sln

They get added to a local storage, just building is enough to have them available on your machine.

There might be another way to build both with one command though

manio143 · 2022-11-23T20:39:49Z

You can set StridePlatforms=Windows;Android and StrideGraphicsApiDependentBuildAll=true properties in Directory.Build.props

Feralnex · 2022-11-24T16:55:25Z

@manio143 couldn't find file to set those properties, but I noticed that i can run script:

set StridePlatforms=Windows;Android
set StrideGraphicsApiDependentBuildAll=true
Stride.sln

But it produces errors inside Visual Studio when i try to build GameStudio...

Error	NETSDK1005	Assets file 'E:\Stride Projects\stride\sources\engine\Stride.UI\obj\project.assets.json' doesn't have a target for 'net6.0-android'. Ensure that restore has run and that you have included 'net6.0-android' in the TargetFrameworks for your project.	Stride.UI	C:\Program Files\dotnet\sdk\6.0.403\Sdks\Microsoft.NET.Sdk\targets\Microsoft.PackageDependencyResolution.targets	267	
Error	NETSDK1005	Assets file 'E:\Stride Projects\stride\sources\tools\Stride.Graphics.RenderDocPlugin\obj\project.assets.json' doesn't have a target for 'net6.0-android'. Ensure that restore has run and that you have included 'net6.0-android' in the TargetFrameworks for your project.	Stride.Graphics.RenderDocPlugin	C:\Program Files\dotnet\sdk\6.0.403\Sdks\Microsoft.NET.Sdk\targets\Microsoft.PackageDependencyResolution.targets	267	
Error	NETSDK1005	Assets file 'E:\Stride Projects\stride\sources\engine\Stride.Voxels\obj\project.assets.json' doesn't have a target for 'net6.0-android'. Ensure that restore has run and that you have included 'net6.0-android' in the TargetFrameworks for your project.	Stride.Voxels	C:\Program Files\dotnet\sdk\6.0.403\Sdks\Microsoft.NET.Sdk\targets\Microsoft.PackageDependencyResolution.targets	267	
Error	NETSDK1005	Assets file 'E:\Stride Projects\stride\sources\engine\Stride.SpriteStudio.Runtime\obj\project.assets.json' doesn't have a target for 'net6.0-android'. Ensure that restore has run and that you have included 'net6.0-android' in the TargetFrameworks for your project.	Stride.SpriteStudio.Runtime	C:\Program Files\dotnet\sdk\6.0.403\Sdks\Microsoft.NET.Sdk\targets\Microsoft.PackageDependencyResolution.targets	267	
Error	NETSDK1005	Assets file 'E:\Stride Projects\stride\sources\engine\Stride.Rendering\obj\project.assets.json' doesn't have a target for 'net6.0-android'. Ensure that restore has run and that you have included 'net6.0-android' in the TargetFrameworks for your project.	Stride.Rendering	C:\Program Files\dotnet\sdk\6.0.403\Sdks\Microsoft.NET.Sdk\targets\Microsoft.PackageDependencyResolution.targets	267	
Error	NETSDK1005	Assets file 'E:\Stride Projects\stride\sources\engine\Stride.Physics\obj\project.assets.json' doesn't have a target for 'net6.0-android'. Ensure that restore has run and that you have included 'net6.0-android' in the TargetFrameworks for your project.	Stride.Physics	C:\Program Files\dotnet\sdk\6.0.403\Sdks\Microsoft.NET.Sdk\targets\Microsoft.PackageDependencyResolution.targets	267	
Error	NETSDK1005	Assets file 'E:\Stride Projects\stride\sources\engine\Stride.Particles\obj\project.assets.json' doesn't have a target for 'net6.0-android'. Ensure that restore has run and that you have included 'net6.0-android' in the TargetFrameworks for your project.	Stride.Particles	C:\Program Files\dotnet\sdk\6.0.403\Sdks\Microsoft.NET.Sdk\targets\Microsoft.PackageDependencyResolution.targets	267	
Error	NETSDK1005	Assets file 'E:\Stride Projects\stride\sources\engine\Stride.Navigation\obj\project.assets.json' doesn't have a target for 'net6.0-android'. Ensure that restore has run and that you have included 'net6.0-android' in the TargetFrameworks for your project.	Stride.Navigation	C:\Program Files\dotnet\sdk\6.0.403\Sdks\Microsoft.NET.Sdk\targets\Microsoft.PackageDependencyResolution.targets	267	
Error	NETSDK1005	Assets file 'E:\Stride Projects\stride\sources\engine\Stride.Input\obj\project.assets.json' doesn't have a target for 'net6.0-android'. Ensure that restore has run and that you have included 'net6.0-android' in the TargetFrameworks for your project.	Stride.Input	C:\Program Files\dotnet\sdk\6.0.403\Sdks\Microsoft.NET.Sdk\targets\Microsoft.PackageDependencyResolution.targets	267	
Error	NETSDK1005	Assets file 'E:\Stride Projects\stride\sources\engine\Stride.Engine\obj\project.assets.json' doesn't have a target for 'net6.0-android'. Ensure that restore has run and that you have included 'net6.0-android' in the TargetFrameworks for your project.	Stride.Engine	C:\Program Files\dotnet\sdk\6.0.403\Sdks\Microsoft.NET.Sdk\targets\Microsoft.PackageDependencyResolution.targets	267

Probably i'm doing something wrong, but before changing those properties everything was fine.

Feralnex · 2022-11-24T17:17:38Z

Maybe the problem lies somewhere else... The reason why I'm asking about it is that after creating Android project in built Stride (and Android earlier) the MyGameActivity.cs has errors:

Severity	Code	Description	Project	File	Line	Suppression State
Error	CS0103	The name 'GameContext' does not exist in the current context	MyGame6.Android	E:\Stride Projects\MyGame6\MyGame6.Android\MyGame6Activity.cs	24	Active
Error	CS0246	The type or namespace name 'StrideActivity' could not be found (are you missing a using directive or an assembly reference?)	MyGame6.Android	E:\Stride Projects\MyGame6\MyGame6.Android\MyGame6Activity.cs	15	Active
Error	CS0234	The type or namespace name 'Starter' does not exist in the namespace 'Stride' (are you missing an assembly reference?)	MyGame6.Android	E:\Stride Projects\MyGame6\MyGame6.Android\MyGame6Activity.cs	6	Active

manio143 · 2022-11-24T17:18:14Z

Did you try to rebuild (or clean, then build)? Regarding props file - you can see examples on the web, it's very similar to how csproj is written.

Feralnex · 2022-11-24T17:23:53Z

@manio143 even during clean similar errors pop up... when trying to rebuild over 12k errors pop up...

tebjan · 2022-11-24T19:02:50Z

@manio143 even during clean similar errors pop up... when trying to rebuild over 12k errors pop up...

Just a sanity check, did you check out the stride sources with git lfs enabled?

Feralnex · 2022-11-24T20:30:09Z

@tebjan yes

ykafia · 2022-12-01T19:23:54Z

If anyone has time to try this, I'll do something this weekend if I get some time.

The resource designer issue might be an issue of conflicting namespace

tebjan · 2023-03-14T14:08:53Z

Is this still an issue after this merge? #1428

Eideren · 2023-11-12T15:49:15Z

Changed this to draft given the conflicts introduced by #1833

ykafia and others added 8 commits November 12, 2021 15:59

ignore configs

005d765

Merge branch 'stride3d:master' into master

8ee77d4

Merge branch 'stride3d:master' into master

f58625e

Merge branch 'stride3d:master' into master

1f5beac

Merge branch 'stride3d:master' into master

970e672

Merge branch 'stride3d:master' into master

5bc78b1

Merge branch 'stride3d:master' into master

882f270

Update app name in android template

9636c51

ykafia marked this pull request as draft July 17, 2022 13:48

ykafia and others added 2 commits July 17, 2022 16:19

removed useless text view that was creating a bug

8c75c45

Update .gitignore

cd574fb

ykafia added 2 commits July 17, 2022 17:38

redo app name

f389b23

Merge branch 'fix-android-resx' of https://github.com/ykafia/stride i…

2fb4936

…nto fix-android-resx

ykafia mentioned this pull request Nov 18, 2022

Can't create new game for Android platform #1562

Open

Feralnex reviewed Nov 18, 2022

View reviewed changes

azeno mentioned this pull request Feb 4, 2023

[Build] Native libraries get copied to runtimes/RID/native folder #1428

Merged

7 tasks

ykafia marked this pull request as ready for review March 14, 2023 16:36

MeharDT mentioned this pull request Sep 23, 2023

iOS Project Template Updated to Support .NET 6 #1833

Merged

7 tasks

Eideren marked this pull request as draft November 12, 2023 15:47

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix android template issues #1456

Fix android template issues #1456

ykafia commented Jul 17, 2022 •

edited

xen2 commented Jul 17, 2022

ykafia commented Jul 17, 2022

ykafia commented Jul 17, 2022

Feralnex Nov 18, 2022

Feralnex Nov 18, 2022

tebjan Nov 18, 2022

Feralnex Nov 18, 2022

Feralnex commented Nov 23, 2022

ykafia commented Nov 23, 2022

manio143 commented Nov 23, 2022

Feralnex commented Nov 24, 2022

Feralnex commented Nov 24, 2022

manio143 commented Nov 24, 2022

Feralnex commented Nov 24, 2022

tebjan commented Nov 24, 2022

Feralnex commented Nov 24, 2022

ykafia commented Dec 1, 2022 •

edited

tebjan commented Mar 14, 2023

Eideren commented Nov 12, 2023

		@@ -1,3 +1,2 @@
		<resources>
		<string name="app_name"><#= Properties.PackageGameDisplayName #></string>

Fix android template issues #1456

Are you sure you want to change the base?

Fix android template issues #1456

Conversation

ykafia commented Jul 17, 2022 • edited

PR Details

Types of changes

Checklist

xen2 commented Jul 17, 2022

ykafia commented Jul 17, 2022

ykafia commented Jul 17, 2022

Feralnex Nov 18, 2022

Choose a reason for hiding this comment

Feralnex Nov 18, 2022

Choose a reason for hiding this comment

tebjan Nov 18, 2022

Choose a reason for hiding this comment

Feralnex Nov 18, 2022

Choose a reason for hiding this comment

Feralnex commented Nov 23, 2022

ykafia commented Nov 23, 2022

manio143 commented Nov 23, 2022

Feralnex commented Nov 24, 2022

Feralnex commented Nov 24, 2022

manio143 commented Nov 24, 2022

Feralnex commented Nov 24, 2022

tebjan commented Nov 24, 2022

Feralnex commented Nov 24, 2022

ykafia commented Dec 1, 2022 • edited

tebjan commented Mar 14, 2023

Eideren commented Nov 12, 2023

ykafia commented Jul 17, 2022 •

edited

ykafia commented Dec 1, 2022 •

edited