-
-
Notifications
You must be signed in to change notification settings - Fork 946
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement "Enable Metrics" setting #1816
Conversation
I think before we merge this, it also needs a consideration of how stride metrics is communicated. A merely functional change will probably lead to no one enabling it due to a general aversion to data collecting. It needs to be clear that the metrics are anonymous, nothing is stored anywhere, and that the data is public and open-source. Ideally also an easy-to-understand overview of what exactly is sent. |
Once I have wiki access, I will add a page on this. @tebjan |
I think being able to articulate how the metrics are being used is important, not only for the engine end-users but us as developers. As a general rule, metrics should only be gathered on an as-needed basis, and only to answer specific questions with clearly defined action-items that will result from the gathered metrics. Gathering metrics with no idea how it's going to be used, or with no actionable outcome regardless of the data gathered should be discouraged. When we enable new metrics it should come with an invitation to help us make a decision about "X" feature or issue, by granting us the metrics we need to make the decision. |
LGTM, it's still keeping it on by default as far as I understood. @JeromyWalsh We don't have any specific behavior metric (yet). |
I noticed that this is only a setting in Game Studio, not in the installer dialog. Is there a clearer way to phrase: "Enable collecting data such as uptime, software usage"? |
Maybe: Name: "Usage Analytics" Description: "Anonymous usage analytics to help the Stride community improve the software. Statistics on installation, version-specific usage, and platform popularity. The data is open-source at https://metrics.stride3d.net" |
Will move this to draft while @NicusorN5 gets back to us with those last few questions |
Hi, I was missing for a while, because my third university year started, so I was left behind regarding what's happening with this PR. I will consider rewording the description and name. |
I hope this is okay as it is. I'm also not sure how to resolve the merge conflict that appeared. U1: I updated the initial post. I have obviously recompiled and opened the editor. |
Fixed the merge conflict, I'll let @tebjan merge this one |
bump |
We'll likely merge this one after the official 4.2 but sent a request to tebjan to get his input anyway |
Thanks ! |
PR Details
Implement a setting that allows toggling usage of metrics.
Description
Just implemented the setting. Tested by debugging values at runtime.
Related Issue
#1815
Motivation and Context
As requested by some Discord users. And also refer to the issue #1815 .
Types of changes
Checklist