[Editor] Remove some windows dependencies in editor libraries #1908
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice one, this tells us which projects are windows platform-specific. LGTM. |
5 tasks
16 tasks
Kryptos-FR
added a commit
to Color-Rise/stride-xplat-editor
that referenced
this pull request
Oct 15, 2023
Some Stride packages still depend on Windows (see stride3d#1908)
7 tasks
Kryptos-FR
added a commit
to Color-Rise/stride-xplat-editor
that referenced
this pull request
Oct 15, 2023
Some Stride packages still depend on Windows (see stride3d#1908). Some Stride packages are not built properly locally.
Kryptos-FR
added a commit
to Kryptos-FR/stride
that referenced
this pull request
Oct 19, 2023
5 tasks
Kryptos-FR
added a commit
to Kryptos-FR/stride
that referenced
this pull request
Oct 19, 2023
Eideren
added a commit
to Eideren/xenko
that referenced
this pull request
Oct 22, 2023
…stride3d#1908)" This reverts commit 329becb.
Eideren
added a commit
that referenced
this pull request
Oct 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Details
Target .NET 6 (cross-platform) for editor libraries that don't have any Windows dependencies.
Description
Introduce
StrideEditorAppTargetFrameworkinsources\targets\Stride.Core.TargetFrameworks.Editor.propsand change existingStrideEditorTargetFrameworkto targetnet6.0only.Related Issue
N/A
Motivation and Context
Some editor libraries should be cross-platform (esp.
Stride.Core.Assets.Quantum). This will allow to reuse these libraries for other tools that don't necessarily target Windows.On the other hand, editor libraries with
Presentationin their name have a strong dependency to either Windows Form or WPF.Types of changes
Checklist