Revert "[Editor] Remove some windows dependencies in editor libraries (#1908)" #1980
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…stride3d#1908)" This reverts commit 329becb.
|
Tested it on my end and this rollback fixes the issue. Merged it right away to avoid more users struggling with this. |
Fydar
reviewed
Oct 23, 2023
| @@ -8,6 +8,8 @@ | |||
| <StrideAssemblyProcessor>true</StrideAssemblyProcessor> | |||
| <StrideAssemblyProcessorOptions>--auto-module-initializer --serialization</StrideAssemblyProcessorOptions> | |||
| <RestorePackages>true</RestorePackages> | |||
| <UseWindowsForms>true</UseWindowsForms> | |||
There was a problem hiding this comment.
Could the removal of these dependencies be preserved?
This does not appear to be the reasons why these changes where causing issues.
There was a problem hiding this comment.
We'll revert the revert once the PRs to fix is in, no need to faff around with individual lines
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Details
This reverts commit 329becb.
Related Issue
See #1968 and #1969
Types of changes
Checklist