Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Build] Restore rules on stride analysers #2089

Merged
merged 2 commits into from
Jan 11, 2024

Conversation

Kryptos-FR
Copy link
Member

This was preventing them from being included in all projects.

Related Issues

Fixes #2073. Partially reverts #2061.

Related to #2045, #2052, and #2055.

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My change requires a change to the documentation.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have built and run the editor to try this change out.

This was preventing them from being included in all projects (see stride3d#2061).
@Kryptos-FR
Copy link
Member Author

Please run a build on TeamCity before merging.

@xen2
Copy link
Member

xen2 commented Dec 30, 2023

Please run a build on TeamCity before merging.

Looks like Eideren ran them and everything looks good.
Should I merge?

@Kryptos-FR
Copy link
Member Author

Should I merge?

It's not critical for the 4.2 release. So I guess we can wait a bit.

@Eideren
Copy link
Collaborator

Eideren commented Jan 7, 2024

Sounds like its ready for merge now that 4.2 is out, can I go ahead ?

@Eideren Eideren merged commit f6d95f4 into stride3d:master Jan 11, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

StrideCompilerServices doesnt resolve
4 participants