Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: [Tests] Added new Test Case for ContentManager #2273

Conversation

dloe
Copy link
Contributor

@dloe dloe commented May 25, 2024

Tests saved object verification for use of isLoaded and TryGetAssetUrl functions.

PR Details

Noticed that coverage in ContentManager required more test cases. Aimed at making a test case to increase coverage.

Description

Added a test case named VerifyLoadedData that creates Test Classes B and A, the normal databaseProvider class as well as 2 assetManagers. We then save our B class with a urlName of "test". We then load this asset and check if the asset is properly loaded. After we run TryGetAssetUrl to lookup the B class object and verify the url output with the resulting urlName.

Related Issue

None found.

Motivation and Context

After some discussions in the discord, it was recommended to look in this area as a place to add more test cases for the existing test suite. Test coverage could be improved here.

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My change requires a change to the documentation.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have built and run the editor to try this change out.

@Eideren Eideren merged commit b6ccdfe into stride3d:master May 25, 2024
2 checks passed
@Eideren
Copy link
Collaborator

Eideren commented May 25, 2024

LGTM, thanks !

@Eideren Eideren changed the title [Tests] Added new Test Case for ContentManager test: [Tests] Added new Test Case for ContentManager May 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants