Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deprecated Topic Operator to work with new images #1765

Merged

Conversation

scholzj
Copy link
Member

@scholzj scholzj commented Jul 2, 2019

Type of change

  • Bugfix

Description

The Topic Operator deployment through CO but outside of EO is deprecated. But as such it should still work. However, it seems it was not properly updated to use the latest images. In particular:

  • The command is wrong
  • The TLS sidecar command is wrong
  • The TLS sidecar pre-stop hook seems to be missing

This PR tries to fix it to make it work. It should be picked for the 0.12.x release branch so that we have it in the next patch release (if we do any).

Checklist

  • Make sure all tests pass
  • Try your changes from Pod inside your Kubernetes and OpenShift cluster, not just locally

@scholzj scholzj added the bug label Jul 2, 2019
@scholzj scholzj added this to the 0.13.0 milestone Jul 2, 2019
@scholzj scholzj requested a review from ppatierno July 2, 2019 21:33
Copy link
Member

@tombentley tombentley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@scholzj scholzj merged commit d01e16e into master Jul 3, 2019
@scholzj scholzj deleted the fix-deprecated-topic-operator-to-work-with-new-images branch July 3, 2019 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants