Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved the contributor docs (#1783) #1799

Merged
merged 3 commits into from
Jul 17, 2019

Conversation

tomncooper
Copy link
Contributor

@tomncooper tomncooper commented Jul 15, 2019

Type of change

  • Enhancement
  • Documentation

Description

  • Separated release instructions into their own file

  • Created quick start guide

  • Added more build options in HACKING file

Checklist

Please go through this checklist and make sure all applicable tasks have been done

  • Update documentation
  • Try your changes from Pod inside your Kubernetes and OpenShift cluster, not just locally
  • Reference relevant issue(s) and close them after merging
  • Update CHANGELOG.md

* Separated release instructions into their own file

* Created quick start guide

* Added more build options in HACKING file
@scholzj scholzj requested a review from Frawless July 15, 2019 13:31
Copy link
Member

@ppatierno ppatierno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work overall! I left just a few comments but no need to re-review.

CONTRIBUTING.md Show resolved Hide resolved
DEV_QUICK_START.md Outdated Show resolved Hide resolved
DEV_QUICK_START.md Outdated Show resolved Hide resolved
DEV_QUICK_START.md Outdated Show resolved Hide resolved
DEV_QUICK_START.md Outdated Show resolved Hide resolved
DEV_QUICK_START.md Outdated Show resolved Hide resolved
DEV_QUICK_START.md Show resolved Hide resolved
CONTRIBUTING.md Show resolved Hide resolved
@scholzj
Copy link
Member

scholzj commented Jul 17, 2019

Congrats to your first Strimzi PR! And thanks!

@scholzj scholzj merged commit cd4dcba into strimzi:master Jul 17, 2019
@tomncooper tomncooper deleted the 1783-improve-contributor-docs branch October 14, 2019 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants