Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ST: add test for bridge loggers + check custom loggers #2256

Merged
merged 4 commits into from
Dec 6, 2019
Merged

ST: add test for bridge loggers + check custom loggers #2256

merged 4 commits into from
Dec 6, 2019

Conversation

Frawless
Copy link
Member

@Frawless Frawless commented Nov 29, 2019 •
edited
Loading

Type of change

  • Enhancement / new feature

Description

This PR introduce:

  • checks that custom loggers loggin level can be set into CR config maps.
  • add test case which covers loggers configuration for Kafka Bridge.
  • Add option to search in logs for components with more than 1 container.

Checklist

  • Write tests
  • Make sure all tests pass

@Frawless Frawless added this to the 0.16.0 milestone Nov 29, 2019
@Frawless
Copy link
Member Author

@strimzi-ci run tests testcase=LogSettingST

@strimzi-ci
Copy link

❗ Build Failed ❗

@Frawless
Copy link
Member Author

@strimzi-ci run tests testcase=LogSettingST profile=regression test_only

@strimzi-ci
Copy link

✔️ Test Summary ✔️

TEST_PROFILE: regression
TEST_CASE: LogSettingST
TOTAL: 10
PASS: 10
FAIL: 0
SKIP: 0

@Frawless
Add custom logers to inline logging, add test case for bridge loggers
3601004 
Signed-off-by: Jakub Stejskal <xstejs24@gmail.com>
@Frawless
Remove useless checks and some fixes
a3105bb 
Signed-off-by: Jakub Stejskal <xstejs24@gmail.com>
@Frawless
Rebase fixups
624bde8 
Signed-off-by: Jakub Stejskal <xstejs24@gmail.com>
@Frawless
Copy link
Member Author

Frawless commented Dec 6, 2019

@strimzi-ci run tests testcase=LogSettingST profile=regression test_only

@strimzi-ci
Copy link

❗ Build Failed ❗

@Frawless
Aditional rebase fixup
88e99ff 
Signed-off-by: Jakub Stejskal <xstejs24@gmail.com>
@Frawless
Copy link
Member Author

Frawless commented Dec 6, 2019

@strimzi-ci run tests testcase=LogSettingST profile=regression test_only

@strimzi-ci
Copy link

✔️ Test Summary ✔️

TEST_PROFILE: regression
TEST_CASE: LogSettingST
TOTAL: 10
PASS: 10
FAIL: 0
SKIP: 0

@Frawless Frawless added the ready for merge Label for PRs which are ready for merge label Dec 6, 2019
@Frawless
Copy link
Member Author

Frawless commented Dec 6, 2019

@scholzj Only changes from latest review was only cause of rebase.

@scholzj scholzj merged commit b33adaf into strimzi:master Dec 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scholzj scholzj scholzj approved these changes

@ppatierno ppatierno ppatierno approved these changes

@see-quick see-quick Awaiting requested review from see-quick

Assignees
No one assigned
Labels
ready for merge Label for PRs which are ready for merge System tests
Projects
None yet
Milestone
0.16.0
Development

Successfully merging this pull request may close these issues.
4 participants
@Frawless @strimzi-ci @scholzj @ppatierno