Use additionalProperties instead of x-kubernetes-preserve-unknown-fields for Map<String, String> fields
#9508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lds for Map<String, String> fields - Closes strimzi#7985 Signed-off-by: Jakub Scholz <www@scholzj.com>
|
/azp run regression |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run upgrade |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run kraft-regression |
|
Azure Pipelines successfully started running 1 pipeline(s). |
scholzj
deleted the
use-additional-properties-instead-of-preserve-unknown-fields-for-string-maps
branch
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description
This PR changes how we generate the CRD schema for fields with type
Map<String, String>where this PR uses theadditionalProeprtiesfield instead ofx-kubernetes-preserve-unknown-fields. That should help users using toosl such as Terraform that seem to have some weird behavior when dealing with thex-kubernetes-preserve-unknown-fieldsflag. However, this can be applied only toMap<String, String>and not toMap<String, Object>, so it is not completely clear how much it will help.This should resolve #7985.
Checklist