Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use additionalProperties in the CRD OpenAPI spec for Maps of Strings instead of x-kubernetes-preserve-unknown-fields #7985

Closed
scholzj opened this issue Jan 27, 2023 · 5 comments · Fixed by #9508

Comments

@scholzj
Copy link
Member

scholzj commented Jan 27, 2023

As discussed in #7979, we should consider using the additionalProperties field instead of x-kubernetes-preserve-unknown-fields to improve the compatibility with other tools and be more in sync with Kubernetes spec. However, we need to keep in mind:

  • That we need to stay backward compatible with existing resources
  • We have places where Maps of Objects are used which should stick with ``x-kubernetes-preserve-unknown-fields`
@scholzj
Copy link
Member Author

scholzj commented Jan 27, 2023

Should be triaged first to see other views!

@scholzj
Copy link
Member Author

scholzj commented Feb 9, 2023

Triaged on 9.2.2023: This can be implemented, but:

  • It seems like it should be used only for places where Map<String, String> is used and not where a deeper objects are (e.g. Connector status section)
  • Backwards compatibility should be tested
  • There is still some risk

@omjikush09
Copy link
Contributor

Hi, Can I work on this?

@scholzj
Copy link
Member Author

scholzj commented Feb 25, 2023

You can if you want. But I'm not sure how easy or straight forward it is TBH.

@omjikush09
Copy link
Contributor

Then I don't think it's a great idea for me to work on this if I get stuck with whom I ask for help. 😕

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants