Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ST: Add missing escape characters for log errors whitelist #9649

Merged
merged 7 commits into from Feb 12, 2024

Conversation

Frawless
Copy link
Member

@Frawless Frawless commented Feb 6, 2024

Type of change

  • Bugfix

Description

There were missing escape characters for two of the whitelisted errors that caused unexpected failures due to not-matching the whitelisted error. This PR should solve it.

Checklist

  • Make sure all tests pass

@Frawless
Copy link
Member Author

Frawless commented Feb 6, 2024

/packit test --labels regression

@Frawless
Copy link
Member Author

Frawless commented Feb 6, 2024

/azp run regression

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@Frawless Frawless added this to the 0.40.0 milestone Feb 7, 2024
@Frawless
Copy link
Member Author

Frawless commented Feb 7, 2024

TF failed due to #9648 and one instance failed during provisioning. Azure is working fine and it doesn't fail due to CO logs error. This PR is now ready for review.

@Frawless Frawless marked this pull request as ready for review February 7, 2024 09:51
Signed-off-by: Jakub Stejskal <xstejs24@gmail.com>
Signed-off-by: Jakub Stejskal <xstejs24@gmail.com>
…client not supported on arm

Signed-off-by: Jakub Stejskal <xstejs24@gmail.com>
@Frawless
Copy link
Member Author

Frawless commented Feb 7, 2024

/azp run regression

@Frawless
Copy link
Member Author

Frawless commented Feb 7, 2024

/packit test --labels regression

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Signed-off-by: Jakub Stejskal <xstejs24@gmail.com>
Signed-off-by: Jakub Stejskal <xstejs24@gmail.com>
@Frawless
Copy link
Member Author

Frawless commented Feb 8, 2024

/packit test --labels regression

@Frawless
Copy link
Member Author

Frawless commented Feb 8, 2024

/azp run regression

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Signed-off-by: Jakub Stejskal <xstejs24@gmail.com>
@Frawless
Copy link
Member Author

Frawless commented Feb 8, 2024

/azp run regression

@Frawless
Copy link
Member Author

Frawless commented Feb 8, 2024

/packit test --labels regression

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Signed-off-by: Jakub Stejskal <xstejs24@gmail.com>
@Frawless Frawless marked this pull request as draft February 9, 2024 10:47
@Frawless
Copy link
Member Author

Frawless commented Feb 9, 2024

/packit test --labels regression

@Frawless
Copy link
Member Author

Frawless commented Feb 9, 2024

/azp run regression

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@Frawless
Copy link
Member Author

/packit test --labels regression

@Frawless Frawless merged commit 8bc7190 into strimzi:main Feb 12, 2024
25 checks passed
@Frawless Frawless deleted the fix-log-matchers branch February 12, 2024 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants