[ST] Re-enable applying of NetworkPolicies during namespace creation #9656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lukas Kral <lukywill16@gmail.com>
Signed-off-by: Lukas Kral <lukywill16@gmail.com>
|
/packit test --labels regression |
|
/azp run upgrade |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp list |
|
/azp run namespace-rbac-scope-regression |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Frawless
approved these changes
Feb 8, 2024
|
/azp run regression |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Test failures in TF are not related to my PR, they are being fixed in #9649 and then in another PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description
During work on
NamespaceManagerI found out that the NetworkPolicies, that were part of the Namespace creation, are not created at all -> theNetworkPolicyTemplates.applyDefaultNetworkPolicy()method, even though named as "apply", just returned the NetworkPolicy object, which was then never actually created (only inOauthAbstractST, where it's done byResourceManagerfrom the beginning).This PR fixes this issue. It adds the correct deployment of NetworkPolicies to
NamespaceManager, so it is on one place and removes it from anywhere else. Also, it removes old and not used methods after changes, that were made in last PRs.Checklist