Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ST] Disable flaky assertNoCoErrorsLogged #9797

Merged
merged 2 commits into from Mar 7, 2024
Merged

[ST] Disable flaky assertNoCoErrorsLogged #9797

merged 2 commits into from Mar 7, 2024

Conversation

jankalinic
Copy link
Contributor

Type of change

  • Refactoring

Description

This PR simply disables method that checks CO logs after each test (which is currently flaky and needs to be reviewed and reworked).

Checklist

  • Write tests
  • Make sure all tests pass
  • Update documentation
  • Check RBAC rights for Kubernetes / OpenShift roles
  • Try your changes from Pod inside your Kubernetes and OpenShift cluster, not just locally
  • Reference relevant issue(s) and close them after merging
  • Update CHANGELOG.md
  • Supply screenshots for visual changes, such as Grafana dashboards

@jankalinic
disable flaky assertNoCoErrorsLogged
fca61bf 
Signed-off-by: jkalinic <jkalinic@redhat.com>
@jankalinic jankalinic self-assigned this Mar 7, 2024
@jankalinic jankalinic added this to the 0.40.0 milestone Mar 7, 2024
im-konge
im-konge approved these changes Mar 7, 2024
View reviewed changes
Copy link
Member

@im-konge im-konge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

scholzj
scholzj approved these changes Mar 7, 2024
View reviewed changes
Copy link
Member

@scholzj scholzj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit. LGTM otherwise.

systemtest/src/test/java/io/strimzi/systemtest/AbstractST.java Show resolved Hide resolved
@jankalinic
fix
40c402f 
Signed-off-by: jkalinic <jkalinic@redhat.com>
scholzj
scholzj approved these changes Mar 7, 2024
View reviewed changes
Copy link
Member

@scholzj scholzj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@scholzj
Copy link
Member

scholzj commented Mar 7, 2024

/azp run acceptance

1 similar comment
@scholzj
Copy link
Member

scholzj commented Mar 7, 2024

/azp run acceptance

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@scholzj scholzj merged commit 73dba1b into strimzi:main Mar 7, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scholzj scholzj scholzj approved these changes

@Frawless Frawless Frawless approved these changes

@see-quick see-quick see-quick approved these changes

@im-konge im-konge im-konge approved these changes

Assignees

@jankalinic jankalinic

Labels
System tests
Projects
None yet
Milestone
0.40.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jankalinic @scholzj @Frawless @see-quick @im-konge