Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ST] Disable flaky assertNoCoErrorsLogged #9797

Merged
merged 2 commits into from
Mar 7, 2024
Merged

[ST] Disable flaky assertNoCoErrorsLogged #9797

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fca61bf
disable flaky assertNoCoErrorsLogged
jankalinic Mar 7, 2024
40c402f
fix
jankalinic Mar 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 3 additions & 1 deletion systemtest/src/test/java/io/strimzi/systemtest/AbstractST.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,7 +170,9 @@ void tearDownTestCase(ExtensionContext extensionContext) throws Exception {
// does not proceed with the next method (i.e., afterEachMustExecute()). This ensures that if such problem happen
// it will always execute the second method.
try {
assertNoCoErrorsLogged(clusterOperator.getDeploymentNamespace(), storageMap.get(extensionContext).getTestExecutionTimeInSeconds());
// This method needs to be disabled for the moment, as it brings flakiness and is unstable due to regexes and current matcher checks.
// Needs to be reworked on what errors to ignore. Better error logging should be added.
//assertNoCoErrorsLogged(clusterOperator.getDeploymentNamespace(), storageMap.get(extensionContext).getTestExecutionTimeInSeconds());
jankalinic marked this conversation as resolved.
Show resolved Hide resolved
} finally {
afterEachMayOverride();
afterEachMustExecute();
Expand Down