Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ability to filter modules from lock file #26

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ngbinh
Copy link

@ngbinh ngbinh commented Jun 25, 2021

This is necessary for multi-module projects where the internal modules
version keeps changing based on the git hash.

This is necessary for multi module projects where the internal modules
version keeps changing
to allow projects an easier way to overwrite their values
@stringbean stringbean added the enhancement New feature or request label Jul 1, 2021
Copy link
Owner

@stringbean stringbean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Can you add some scripted tests for this and then I can get it merged in?

@@ -30,6 +31,7 @@ object DependencyLockPlugin extends AutoPlugin {
val dependencyLockFile = settingKey[File]("lockfile to generate")
val dependencyLockWrite = taskKey[File]("write dependencies to lockfile")
val dependencyLockRead = taskKey[Option[DependencyLockFile]]("read dependencies from lockfile")
val dependencyLockExclusion = settingKey[ModuleFilter]("lockfile module exclusion filter")
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you change this to:

Suggested change
val dependencyLockExclusion = settingKey[ModuleFilter]("lockfile module exclusion filter")
val dependencyLockModuleFilter = settingKey[ModuleFilter]("exclusion filter for dependencies")

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants