Skip to content
This repository has been archived by the owner on Jul 30, 2021. It is now read-only.

Adds localizations to podspec #37

Closed
wants to merge 1 commit into from

Conversation

crmitchelmore
Copy link

No description provided.

@loudnate
Copy link
Contributor

Developers who use this library can add their own strings table named STPaymentLocalizable.strings to their project. It is my understanding that Including these files in the Podspec will prevent developers from providing their own en localization.

If you want the project to use the English strings as a default, consider a PR changing the NSLocalizedString calls to use NSLocalizedStringWithDefaultValue.

@loudnate
Copy link
Contributor

AFNetworking can be used as an example. Strings are localized in the codebase referencing the AFNetworking table, but AFNetworking.strings isn't included in the Podspec.

@crmitchelmore
Copy link
Author

I can see the benefits of being able to set your own localizations and I'm sure those guys are doing it the right way.

I think, in this case, it's more appropriate to include them OR remove localization by default, and put it on a separate branch perhaps; It may even make sense to have people submit pull requests for their localizations, assuming they are 'correct', for others to take advantage of.

The issue I have with this approach is that it doesn't work out the box. Everyone who uses this Pod will either create a hack themselves, come here and find out what's wrong or just give up and use something else. At the very least add it to the installation instructions.

@phillco
Copy link
Contributor

phillco commented Mar 24, 2014

Agreed that it should work out the box; I've made a commit that uses NSLocalizedStringWithDefaultValue to this end.

@phillco phillco closed this Mar 24, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants