This repository has been archived by the owner on Jan 10, 2018. It is now read-only.
Integrate changes from Stripe Checkout #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some mobile devices only emit an `input` event, and others will emit both `input` and `key*` events. This change addresses both cases: * For those that only support `input`, the `reFormat*` functions will update the element with the proper value on the next tick. * For those that support both, the `key*` defaults will be prevented and the element will be updated with the proper value on the next tick. Attempting to do both in the same tick results in incorrect cursor positioning.
|
Review? @metcalf @michaelvillar |
|
Supersedes #43, though not perfectly. |
|
Also #56. Phew. |
|
Or maybe you could review, @SlexAxton, since you're technically to blame for nearly everything in this repo :P |
|
This looks good to me. Sorry for the belated review! |
jamesreggio
added a commit
that referenced
this pull request
Jul 17, 2014
Integrate changes from Stripe Checkout
This was referenced Jul 18, 2014
Closed
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes some bugs we've found while using jquery.payment in Stripe Checkout.
Specifically, it addresses problems with:
$.payment.formatCardNumberThe changes in 273d79a are a bit risky, so it would be great to get some validation that they work as expected on Android and all other platforms. These changes supersede the work done in #99, which was great, but didn't fix the caret positioning problem on Android Firefox.
This PR is likely to address or supersede the following issues: #46 #56 #60 #75 #77 #94 #96 #97