Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setOnNotificationsChange Updated to carry payload #132

Merged
merged 4 commits into from
Jul 5, 2024

Conversation

riquelme-stripe
Copy link
Contributor

Previous definition was empty. Updating to actual API Review functionality.

@riquelme-stripe
Copy link
Contributor Author

r? @jorgea-stripe @hliana-stripe

@hliana-stripe
Copy link
Contributor

hliana-stripe commented Jul 5, 2024

can we include a screen recording of this working in furever? (console log is fine to show that we see the total/action required being passed thru)

@riquelme-stripe
Copy link
Contributor Author

riquelme-stripe commented Jul 5, 2024

The rendering behavior isn't fully ready yet as you can see but everything is working as it should behind the hood.

@riquelme-stripe
Copy link
Contributor Author

Screen.Recording.2024-07-05.at.12.49.39.PM.mov

Copy link
Contributor

@hliana-stripe hliana-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome, thx for the screenrecording! - make sure to include this change in beta as well

@riquelme-stripe riquelme-stripe merged commit a38f971 into master Jul 5, 2024
2 checks passed
@riquelme-stripe riquelme-stripe deleted the riquelme-updateCallback branch July 5, 2024 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants