Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BoundsViz #450

Merged
merged 4 commits into from
Jan 21, 2020
Merged

BoundsViz #450

merged 4 commits into from
Jan 21, 2020

Conversation

avibryant
Copy link
Collaborator

Adds a BoundsViz by hacking up RealViz.
Also fixes a Bounds math edge case, and fixes Tracer to compile again.

@avibryant avibryant mentioned this pull request Jan 21, 2020
@avibryant avibryant merged commit 464727d into 0.3-dev Jan 21, 2020
@codecov-io
Copy link

codecov-io commented Jan 21, 2020

Codecov Report

Merging #450 into 0.3-dev will decrease coverage by 0.42%.
The diff coverage is 21.73%.

Impacted file tree graph

@@             Coverage Diff             @@
##           0.3-dev     #450      +/-   ##
===========================================
- Coverage    50.67%   50.25%   -0.43%     
===========================================
  Files           75       76       +1     
  Lines         2885     2943      +58     
  Branches       189      174      -15     
===========================================
+ Hits          1462     1479      +17     
- Misses        1423     1464      +41
Impacted Files Coverage Δ
...rc/main/scala/com/stripe/rainier/ir/GraphViz.scala 0% <0%> (ø) ⬆️
...n/scala/com/stripe/rainier/compute/BoundsViz.scala 0% <0%> (ø)
...main/scala/com/stripe/rainier/compute/Target.scala 89.88% <0%> (+1.25%) ⬆️
...ain/scala/com/stripe/rainier/compute/RealViz.scala 0% <0%> (ø) ⬆️
...c/main/scala/com/stripe/rainier/compute/Real.scala 87.5% <100%> (+1.01%) ⬆️
...main/scala/com/stripe/rainier/compute/Bounds.scala 84.93% <100%> (+11.01%) ⬆️
...src/main/scala/com/stripe/rainier/log/Logger.scala 38.09% <0%> (+4.76%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 19c9fbe...a595302. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants