Project refactor #13
Project refactor #13
Conversation
| project: usersec | ||
| action: enforce | ||
| allowed_domains: | ||
| - '$example1\.com$' # Matches all Lyft+subdomains |
| @@ -0,0 +1,18 @@ | |||
| broken: | |||
There was a problem hiding this comment.
This file should probably have comments explaining why it's broken.
| project: usersec | ||
| action: enforce | ||
| allowed_domains: | ||
| - '^example1\.com$' # Matches all Lyft+subdomains |
| project: usersec | ||
| action: enforce | ||
| allowed_domains: | ||
| - 'example1\.com$' # Matches all Lyft+subdomains |
cmd/smokescreen/smokescreen.go
Outdated
|
|
||
| app := cli.NewApp() | ||
| app.Name = "smokescreen" | ||
| app.Usage = "A simple HTTP proxy that fogs over naughty URLs" |
There was a problem hiding this comment.
How about "...that prevents SSRF and can restrict destinations" or something else less cutesy and more practical?
There was a problem hiding this comment.
I'm not against that. I just took that from the repo description on github.com/stripe/smokescreen.
internal/pkg/egressacl/yaml.go
Outdated
| "regexp" | ||
| ) | ||
|
|
||
| type EgressAclYamlEntry struct { |
There was a problem hiding this comment.
The class naming is kind of weird here-- EgressAclConfiguration maps directly to the YAML configuration file, but EgressAclYaml and EgressAclYamlEntry are the internal config format that doesn't map directly to YAML.
There was a problem hiding this comment.
Yeah, I was a bit lenient with this one since it's just an implementation detail behind an interface. I hear you though!
|
ptal @rlk-stripe |
|
|
||
| import "github.com/stretchr/testify/assert" | ||
| import "github.com/stripe/smokescreen/pkg/egressacl/decision" | ||
| import "testing" |
There was a problem hiding this comment.
I don't think this is gofmt'd correctly?
|
lgtm |
tremblay-stripe
force-pushed
the
tremblay-project-refactor
branch
from
de0ba18
to
20bbe53
Compare
tremblay-stripe
force-pushed
the
tremblay-project-refactor
branch
from
20bbe53
to
b388f1b
Compare
r?: @rlk-stripe
This PR kills some globals and parameterizes parts of Smokescreen.