Set card type after card number has been mutated #34
Conversation
|
Thanks @tbellenger completely missed that blank check in getType |
|
Hi @Numan1617, sorry for the very late reply! This looks good to me, except I think it'd be cleaner to reset r? @brandur cc @stripe/api-libraries |
|
@olivierbellone Unfortunately since making this PR I've deleted my repo so I can't update with your requested change. Would you mind if I were to open a new PR to address the original issue and your requested change? |
|
@Numan1617 Absolutely not! Thanks for taking the trouble. |
| @@ -280,6 +280,8 @@ public String getNumber() { | |||
|
|
|||
| public void setNumber(String number) { | |||
| this.number = number; | |||
| this.type = ""; | |||
| this.type = getType(); | |||
There was a problem hiding this comment.
This is pretty minor, but I think that getType() will always return a value so you can probably just leave out blanking this.type on the previous line completely.
|
This has been addressed elsewhere |
Resolves #33