Fix trigger checkout.session.async_payment_succeeded to use SEPA Debit #1105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewers
r? @
cc @stripe/developer-products
Summary
Fix trigger checkout.session.async_payment_succeeded to use SEPA Debit
Fixes #1104
The trigger was changed a few months ago in #929 but this was done incorrectly. It uses a card to confirm the Checkout Session which would never cause that Event to be triggered. We switched away from BACS Debit that is not supported in most countries but we still broke the trigger. I'm switching to SEPA Debit which is supported in a lot of countries (though not all) making the trigger work again.
Note that a future improvement would be for the CLI to dynamically pick the right currency and payment method type to trigger that Event but this would be a substantial redesign of triggers.