Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating checkout.session.async_payment_suceeded with US payment method #929

Merged
merged 1 commit into from
Aug 4, 2022

Conversation

gracegoo-stripe
Copy link
Contributor

Reviewers

r? @etsai-stripe
cc @stripe/developer-products

Summary

I noticed that the checkout.session.async_payment_succeeded fixture is identical to its failure counterpart minus the expected error. This means one of those will always fail to trigger depending on the account. I updated the fixture to use US payment methods.

Before:

➜  stripe-cli git:(master) ✗ stripe-workspace trigger --log-level=debug  checkout.session.async_payment_succeeded 
Fixture: Setting up fixture for: checkout_session
Running fixture for: checkout_session
Trigger failed: Request failed, status=400, body={
  "error": {
    "message": "The payment method type provided: bacs_debit is invalid. Please ensure the provided type is activated in your dashboard (https://dashboard.stripe.com/account/payments/settings) and your account is enabled for any preview features that you are trying to use. See https://stripe.com/docs/payments/payment-methods/integration-options for supported payment method, currency, and country combinations.",
    "param": "payment_method_types",
    "type": "invalid_request_error"
  }
}

After:

➜  stripe-cli git:(master) ✗ stripe-workspace trigger --log-level=debug  checkout.session.async_payment_succeeded Fixture: Setting up fixture for: checkout_session
Running fixture for: checkout_session
Setting up fixture for: payment_page
Running fixture for: payment_page
Setting up fixture for: payment_method
Running fixture for: payment_method
Setting up fixture for: payment_page_confirm
Running fixture for: payment_page_confirm
Trigger succeeded! Check dashboard for event details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants