Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix checkout.session.async_payments_* triggers #503

Merged
merged 3 commits into from
Sep 23, 2020
Merged

Conversation

ahlee-stripe
Copy link
Contributor

@ahlee-stripe ahlee-stripe commented Sep 16, 2020

Reviewers

r? @stripe/developer-products
cc @stripe/dev-platform

Summary

Testing

Switched to a UK based stripe account. Ran $ stripe-dev trigger checkout.session.async_payment_succeeded and $ stripe-dev trigger checkout.session.async_payment_failed while using stripe listen. Confirmed that all the events came through as expected.

@ahlee-stripe ahlee-stripe changed the title Update Fix checkout.session.async_payments_* triggers Sep 16, 2020
@tomer-stripe
Copy link
Collaborator

Thanks @ahlee-stripe! This looks good. Let me see if I can test out the fixtures version error later, that came up in my PR too (https://github.com/stripe/stripe-cli/pull/502/files#diff-133d387253cca3c9f0d5be8b5c845987) and I'm wondering if there's a difference (or if we care) about rendering it as a decimal.

@ahlee-stripe
Copy link
Contributor Author

@tomer-stripe If you want I can pull out the fixtures error fix so more testing can happen on it

@tomer-stripe
Copy link
Collaborator

@ahlee-stripe yea that would be great, ty!

@ahlee-stripe
Copy link
Contributor Author

@tomer-stripe Done! Removed the conversion fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants